Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of github.com/hashicorp/go-version #1766

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Replace use of github.com/hashicorp/go-version #1766

merged 5 commits into from
Feb 13, 2025

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 6, 2025

Resolve #1753

Replace with github.com/Masterminds/semver/v3

@MrAlias MrAlias force-pushed the switch-go-version branch 2 times, most recently from 619d81d to 388f043 Compare February 6, 2025 21:35
@MrAlias MrAlias added this to the v0.21.0 milestone Feb 6, 2025
@MrAlias MrAlias marked this pull request as ready for review February 6, 2025 21:35
@MrAlias MrAlias requested a review from a team as a code owner February 6, 2025 21:36
@MrAlias MrAlias marked this pull request as draft February 6, 2025 21:57
@MrAlias

This comment was marked as resolved.

Sign in to view
@MrAlias

This comment was marked as resolved.

Sign in to view
@MrAlias MrAlias marked this pull request as ready for review February 7, 2025 17:14
@MrAlias MrAlias force-pushed the switch-go-version branch 2 times, most recently from 295de30 to 1a4c35e Compare February 10, 2025 19:32
kakkoyun
kakkoyun approved these changes Feb 11, 2025
View reviewed changes
Copy link

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I have used both of the packages before and gone through similar migration. The changes look straight forward.

@kakkoyun kakkoyun mentioned this pull request Feb 11, 2025
Merged
@MrAlias MrAlias merged commit 503572b into open-telemetry:main Feb 13, 2025
29 checks passed
@MrAlias MrAlias deleted the switch-go-version branch February 13, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.

Replace use of github.com/hashicorp/go-version
3 participants
@MrAlias @kakkoyun @pellared