Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kick-off Go auto-instrumentation group #1

Closed
jmacd opened this issue Aug 3, 2022 · 11 comments
Closed

Kick-off Go auto-instrumentation group #1

jmacd opened this issue Aug 3, 2022 · 11 comments

Comments

@jmacd
Copy link
Contributor

jmacd commented Aug 3, 2022

There have been two donation proposals for different forms of auto-instrumentation:

#2 @edeNFed
#3 @pdelewski

There is also an ongoing effort to build community support for the "Launcher" concept, a simplified way to start OTel SDKs via configuration and environment variables. @JamieDanielson @robbkidd @kentquirk @MikeGoldsmith

I have seeded the maintainers of this repository using @MadVikingGod @MrAlias @Aneurysm9 and myself. The goal is to build new maintainers and owners for this group eventually. Existing @open-telemetry/go-approvers and @open-telemetry/go-triagers are welcome but have not been added to this repo.

My goal in bringing all of these groups together is that we begin to standardize on the ways that users will configure SDKs and auto-instrumentation via packages in this repository. As I mentioned in #2, I think it would be great to see collaboration with the Go team in this area, too.

Please discuss, and thanks for the interest.

@MrAlias
Copy link
Contributor

MrAlias commented Aug 3, 2022

I would like to propose we have a kick off meeting. I'm currently AFK, but can post a doodle poll to determine the best time (or if someone else feels inclined, feel free to add one). I am thinking sometime next week if that works for everyone?

@Aneurysm9
Copy link
Member

I'll be traveling next week, so anything other than Friday might be hard for me to make, but +1 to a poll for times.

@MrAlias
Copy link
Contributor

MrAlias commented Aug 3, 2022

I'll be traveling next week, so anything other than Friday might be hard for me to make, but +1 to a poll for times.

I'll include next Friday in the poll, and dates the week after instead.

@MrAlias
Copy link
Contributor

MrAlias commented Aug 3, 2022

Here is a doodle poll link. If you would like to participate in the kick-off meeting, please respond to that poll by next Wednesday (2022-08-10) 5pm Pacific time. I will create a meeting for the kick-off on the OTel calendar based on the responses then.

cc @MadVikingGod @Aneurysm9 @JamieDanielson @robbkidd @kentquirk @MikeGoldsmith @edeNFed @pdelewski @jmacd @open-telemetry/go-approvers @open-telemetry/go-triagers

@pdelewski
Copy link
Member

pdelewski commented Aug 3, 2022

This week I started 2 weeks vacation, so for me, week starting 15.08 would work best, however will try respond till next wednesday

@MrAlias
Copy link
Contributor

MrAlias commented Aug 15, 2022

I was not able to find a time that worked for everyone with the last doodle poll. I will put another one together and post it here in a bit.

@edeNFed
Copy link
Contributor

edeNFed commented Aug 26, 2022

Any updates? I'll be happy to help in scheduling the meeting if needed.

@MrAlias
Copy link
Contributor

MrAlias commented Aug 26, 2022

Any updates? I'll be happy to help in scheduling the meeting if needed.

Sorry about the delay, here is a link to the new poll.

The poll is for the week of the 5th-9th of September. Please try to respond by next Wednesday (2022-08-31), I will look to create the meeting at the end of that date.

cc @MadVikingGod @Aneurysm9 @JamieDanielson @robbkidd @kentquirk @MikeGoldsmith @edeNFed @pdelewski @jmacd @open-telemetry/go-approvers @open-telemetry/go-triagers

@MrAlias
Copy link
Contributor

MrAlias commented Sep 2, 2022

It looks like Tuesday September 6th 9:30am-10:30am (Pacific time) is the most available time. I'll add a meeting to the OTel calendar for then.

@pdelewski you had listed this as "if need be". I'm hoping to have @dashpole there otherwise I would have gone with Monday morning. Are you okay with this?

@pdelewski
Copy link
Member

@MrAlias I'm ok with this and will join. I listed this as "if need be" due to other activity at that time.

@MrAlias
Copy link
Contributor

MrAlias commented Sep 7, 2022

Kick-off meeting agenda:

  1. (Tyler) Administrative:
    1. When should we have SIG meetings?
      1. Bi-weekley
      2. Next meeting the 20th of Sep.
    2. Repository name, opentelemetry-go-instrumentation, is this okay for all?
      1. This is from OTel precedent
    3. Teams: maintainers and approvers.
  2. (Tyler) Project readme needed
  3. (Tyler) Missing issues?
  4. (Eden) What this SIG is going to work on? (copied from jmacd’s technical committee response to the donations)
    1. Runtime automatic instrumentation
    2. Compile time automatic instrumentation
    3. Automatic Go OpenTelemetry SDK configuration
    4. Better integration between Go built-in diagnostic features (like pprof) and OpenTelemetry SDK
    5. (Runtime metrics: To be discussed in this week’s Go SIG. -jmacd)

Kick-off meeting notes

  • The runtime eBPF filter and compile time code annotation are complimentary.
  • We have two main project: eBPF, and compile annotation
    • We need 3+ people to work on a project all from different companies
  • Next SIG meeting:
    • Demo both approaches
    • Get a limitation of both approaches
    • Get an understanding of the benefits of both
  • We should consider the “auto” configuration of the SDK out of the initial scope of this project.
  • We need to communicate what is being done on user behalf so they know about legal implications about licensing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants