Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lychee new cache-exclude-status option and upgrade lychee-action #6323

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Nov 12, 2024

Lychee's cache-exclude-status option has shipped. So we can use it rather than ignore 429s.
This also upgrades lychee-action to 2.1.0. We had to revert that in #6229 due to a regression, which was fixed in lycheeverse/lychee-action#255

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Nov 12, 2024
@dmathieu dmathieu changed the title Use lychee new cache-exclude-status option Use lychee new cache-exclude-status option and upgrade lychee-action Nov 12, 2024
@dmathieu dmathieu marked this pull request as ready for review November 12, 2024 10:32
@dmathieu dmathieu requested a review from a team as a code owner November 12, 2024 10:32
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.8%. Comparing base (5b9cf72) to head (01e63e0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6323   +/-   ##
=====================================
  Coverage   66.8%   66.8%           
=====================================
  Files        193     193           
  Lines      15580   15580           
=====================================
+ Hits       10408   10414    +6     
+ Misses      4881    4877    -4     
+ Partials     291     289    -2     

see 1 file with indirect coverage changes

@pellared
Copy link
Member

pellared commented Nov 14, 2024

@dmathieu

can we somehow get rid of:

* [429] [https://github.com/open-telemetry/opentelemetry-go/commits/main](https://github.com/open-telemetry/opentelemetry-go/commits/main) | Cached: Error (cached)

or does it mean that it still does not work as expected?

@dmathieu
Copy link
Member Author

I think that means it works as expected. We currently cache 429s, and this PR uses the cache.
Once the cache is renewed, 429s won't be cached anymore, and they will be retried.

@pellared
Copy link
Member

Once the cache is renewed, 429s won't be cached anymore, and they will be retried.

I am just not sure if the cache would be ever renewed given the cached error. Still, not a blocker. I think we can merge this PR.

@dmathieu
Copy link
Member Author

The cache has a finite duration. It is renewed every day.

@pellared pellared merged commit 315b0af into open-telemetry:main Nov 14, 2024
25 checks passed
@dmathieu dmathieu deleted the lychee-cache-exlude-status branch November 14, 2024 13:40
@MrAlias MrAlias added this to the v1.33.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants