Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code owner policy #5555

Merged
merged 11 commits into from
May 14, 2024
Merged

Add code owner policy #5555

merged 11 commits into from
May 14, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented May 9, 2024 •
edited
Loading

Close #2834

@MrAlias MrAlias marked this pull request as ready for review May 9, 2024 20:24
@MrAlias MrAlias requested a review from a team May 9, 2024 20:24
dmathieu
dmathieu reviewed May 13, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
dashpole
dashpole approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add anything about code owner removal? E.g. if someone becomes inactive?

@MrAlias
Copy link
Contributor Author

MrAlias commented May 14, 2024

Do we want to add anything about code owner removal? E.g. if someone becomes inactive?

I'm happy to add something. What do you think our policy should be?

@dmathieu
Copy link
Member

How about something along the lines of:

Code Owners are expected to remove their ownership if they cannot fulfill their responsibilities anymore.
Existing Code Owners may remove ownership of an owner if they are unable to demonstrate their investment.

@dashpole
Copy link
Contributor

Maybe

Code Owners are expected to remove their ownership if they cannot fulfill their responsibilities anymore.
Maintainers or existing code owners may remove ownership of an owner if they are unable to demonstrate their investment.

@MrAlias
Copy link
Contributor Author

MrAlias commented May 14, 2024 

Existing Code Owners may remove ownership of an owner if they are unable to demonstrate their investment.

Do we want to quantify "unable to demonstrate their investment"?

Does this mean they are inactive for a month or two? Have they changed jobs and their focus isn't in the area any more?

@dmathieu
Copy link
Member

Some instrumentations have less than monthly updates.
How would we say someone has been inactive for too long if it's the instrumentation which isn't getting activity?

We're being pretty clear in this doc that it's an oligarchy, and we'll accept whoever we want (which is fine). I think we can say the same for removing folks.

@MrAlias
Copy link
Contributor Author

MrAlias commented May 14, 2024

Some instrumentations have less than monthly updates. How would we say someone has been inactive for too long if it's the instrumentation which isn't getting activity?

We're being pretty clear in this doc that it's an oligarchy, and we'll accept whoever we want (which is fine). I think we can say the same for removing folks.

I would like to avoid the situation where there are disagreeing personalities that become the reason to disqualify an owner.

Having explicit requirements for this dismissal helps prevent this.

@dashpole
Copy link
Contributor

6 months seems like a generous amount of time. We can always add "or at the discretion of maintainers" if we want to give ourselves flexibility.

@MrAlias
Copy link
Contributor Author

MrAlias commented May 14, 2024

Updated. PTAL

dmathieu
dmathieu approved these changes May 14, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit 5422b90 into open-telemetry:main May 14, 2024
23 checks passed
@MrAlias MrAlias deleted the doc-code-owner branch May 14, 2024 20:01
zailic pushed a commit to zailic/opentelemetry-go-contrib that referenced this pull request May 20, 2024
@MrAlias @dmathieu @zailic
Add code owner policy (open-telemetry#5555)
8199241 
* Add Code Owners policy

* Add Code Owner Request Issue template

* Add changelog entry

* Fix lint

* Apply suggestions from code review

Co-authored-by: Damien Mathieu <[email protected]>

* Add Removing Code Ownership section

* Apply suggestions from code review

Co-authored-by: Damien Mathieu <[email protected]>

---------

Co-authored-by: Damien Mathieu <[email protected]>
@MrAlias MrAlias mentioned this pull request May 21, 2024
Merged
MrAlias added a commit that referenced this pull request May 21, 2024
@MrAlias
Release v1.27.0/v0.52.0/v0.21.0/v0.7.0/v0.2.0 (#5628)
007ae66 
### Added

- Add the new `go.opentelemetry.io/contrib/instrgen` package to provide
auto-generated source code instrumentation. (#3068, #3108)
- Add an experimental `OTEL_METRICS_PRODUCERS` environment variable to
`go.opentelemetry.io/contrib/autoexport` to be set metrics producers.
(#5281)
- `prometheus` and `none` are supported values. You can specify multiple
producers separated by a comma.
- Add `WithFallbackMetricProducer` option that adds a fallback if the
`OTEL_METRICS_PRODUCERS` is not set or empty.
- The `go.opentelemetry.io/contrib/processors/baggage/baggagetrace`
module. This module provides a Baggage Span Processor. (#5404)
- Add gRPC trace `Filter` for stats handler to
`go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`.
(#5196)
- Add a repository Code Ownership Policy. (#5555)
- The `go.opentelemetry.io/contrib/bridges/otellogrus` module. This
module provides an OpenTelemetry logging bridge for
`github.com/sirupsen/logrus`. (#5355)
- The `WithVersion` option function in
`go.opentelemetry.io/contrib/bridges/otelslog`. This option function is
used as a replacement of `WithInstrumentationScope` to specify the
logged package version. (#5588)
- The `WithSchemaURL` option function in
`go.opentelemetry.io/contrib/bridges/otelslog`. This option function is
used as a replacement of `WithInstrumentationScope` to specify the
semantic convention schema URL for the logged records. (#5588)
- Add support for Cloud Run jobs in
`go.opentelemetry.io/contrib/detectors/gcp`. (#5559)

### Changed

- The gRPC trace `Filter` for interceptor is renamed to
`InterceptorFilter`. (#5196)
- The gRPC trace filter functions `Any`, `All`, `None`, `Not`,
`MethodName`, `MethodPrefix`, `FullMethodName`, `ServiceName`,
`ServicePrefix` and `HealthCheck` for interceptor are moved to
`go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/filters/interceptor`.
With this change, the filters in
`go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`
are now working for stats handler. (#5196)

- `NewLogger` now accepts a `name` `string` as the first argument. This
parameter is used as a replacement of `WithInstrumentationScope` to
specify the name of the logger backing the underlying `Handler`. (#5588)
- `NewHandler` now accepts a `name` `string` as the first argument. This
parameter is used as a replacement of `WithInstrumentationScope` to
specify the name of the logger backing the returned `Handler`. (#5588)
- Upgrade all dependencies of `go.opentelemetry.io/otel/semconv/v1.24.0`
to `go.opentelemetry.io/otel/semconv/v1.25.0`. (#5605)

### Removed

- The `WithInstrumentationScope` option function in
`go.opentelemetry.io/contrib/bridges/otelslog` is removed. Use the
`name` parameter added to `NewHandler` and `NewLogger` as well as
`WithVersion` and `WithSchema` as replacements. (#5588)

### Deprecated

- The `InterceptorFilter` type in
`go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`
is deprecated. (#5196)
khushijain21 pushed a commit to khushijain21/opentelemetry-go-contrib that referenced this pull request May 22, 2024
@MrAlias @khushijain21
Release v1.27.0/v0.52.0/v0.21.0/v0.7.0/v0.2.0 (open-telemetry#5628)
b10f0e3 
### Added

- Add the new `go.opentelemetry.io/contrib/instrgen` package to provide
auto-generated source code instrumentation. (open-telemetry#3068, open-telemetry#3108)
- Add an experimental `OTEL_METRICS_PRODUCERS` environment variable to
`go.opentelemetry.io/contrib/autoexport` to be set metrics producers.
(open-telemetry#5281)
- `prometheus` and `none` are supported values. You can specify multiple
producers separated by a comma.
- Add `WithFallbackMetricProducer` option that adds a fallback if the
`OTEL_METRICS_PRODUCERS` is not set or empty.
- The `go.opentelemetry.io/contrib/processors/baggage/baggagetrace`
module. This module provides a Baggage Span Processor. (open-telemetry#5404)
- Add gRPC trace `Filter` for stats handler to
`go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`.
(open-telemetry#5196)
- Add a repository Code Ownership Policy. (open-telemetry#5555)
- The `go.opentelemetry.io/contrib/bridges/otellogrus` module. This
module provides an OpenTelemetry logging bridge for
`github.com/sirupsen/logrus`. (open-telemetry#5355)
- The `WithVersion` option function in
`go.opentelemetry.io/contrib/bridges/otelslog`. This option function is
used as a replacement of `WithInstrumentationScope` to specify the
logged package version. (open-telemetry#5588)
- The `WithSchemaURL` option function in
`go.opentelemetry.io/contrib/bridges/otelslog`. This option function is
used as a replacement of `WithInstrumentationScope` to specify the
semantic convention schema URL for the logged records. (open-telemetry#5588)
- Add support for Cloud Run jobs in
`go.opentelemetry.io/contrib/detectors/gcp`. (open-telemetry#5559)

### Changed

- The gRPC trace `Filter` for interceptor is renamed to
`InterceptorFilter`. (open-telemetry#5196)
- The gRPC trace filter functions `Any`, `All`, `None`, `Not`,
`MethodName`, `MethodPrefix`, `FullMethodName`, `ServiceName`,
`ServicePrefix` and `HealthCheck` for interceptor are moved to
`go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/filters/interceptor`.
With this change, the filters in
`go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`
are now working for stats handler. (open-telemetry#5196)

- `NewLogger` now accepts a `name` `string` as the first argument. This
parameter is used as a replacement of `WithInstrumentationScope` to
specify the name of the logger backing the underlying `Handler`. (open-telemetry#5588)
- `NewHandler` now accepts a `name` `string` as the first argument. This
parameter is used as a replacement of `WithInstrumentationScope` to
specify the name of the logger backing the returned `Handler`. (open-telemetry#5588)
- Upgrade all dependencies of `go.opentelemetry.io/otel/semconv/v1.24.0`
to `go.opentelemetry.io/otel/semconv/v1.25.0`. (open-telemetry#5605)

### Removed

- The `WithInstrumentationScope` option function in
`go.opentelemetry.io/contrib/bridges/otelslog` is removed. Use the
`name` parameter added to `NewHandler` and `NewLogger` as well as
`WithVersion` and `WithSchema` as replacements. (open-telemetry#5588)

### Deprecated

- The `InterceptorFilter` type in
`go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`
is deprecated. (open-telemetry#5196)
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@dmathieu dmathieu dmathieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

Define an ownership model for packages that live in this repository
4 participants
@MrAlias @dmathieu @dashpole @pellared