New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WithInstrumentationScope change needs getstarted updates #5706

Closed

xorima opened this issue Jun 2, 2024 · 1 comment

Labels

bug

Milestone

xorima commented Jun 2, 2024

Description

Type: Documentation
Under: https://opentelemetry.io/docs/languages/go/getting-started/#add-custom-instrumentation there is a part of the guide where the code uses:

	logger = otelslog.NewLogger(
		otelslog.WithInstrumentationScope(instrumentation.Scope{
			Name: name,
		}),
	)

with changes in 1.27.0 https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.27.0 this func was replaced so the get started should also be updated

Steps To Reproduce

Follow the get started guide, code fails to work due to renamed function

Expected behavior

Guide to show us how to get things working correctly.

xorima added the bug label

Member

dmathieu commented Jun 2, 2024

Fixed in open-telemetry/opentelemetry.io#4577

dmathieu closed this as completed

pellared added this to the untracked milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment