From 315b0af3985549f3a0552bf485a93929b78a0359 Mon Sep 17 00:00:00 2001 From: Damien Mathieu <42@dmathieu.com> Date: Thu, 14 Nov 2024 14:37:33 +0100 Subject: [PATCH] Use lychee new cache-exclude-status option and upgrade lychee-action (#6323) Lychee's `cache-exclude-status` option has shipped. So we can use it rather than ignore 429s. This also upgrades lychee-action to 2.1.0. We had to revert that in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6229 due to a regression, which was fixed in https://github.com/lycheeverse/lychee-action/pull/255 --- .github/workflows/links-fail-fast.yml | 5 ++--- .github/workflows/links.yml | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/links-fail-fast.yml b/.github/workflows/links-fail-fast.yml index 473c56ff782..d97bf5405b7 100644 --- a/.github/workflows/links-fail-fast.yml +++ b/.github/workflows/links-fail-fast.yml @@ -20,10 +20,9 @@ jobs: restore-keys: cache-lychee- - name: Link Checker - uses: lycheeverse/lychee-action@v1.10.0 + uses: lycheeverse/lychee-action@v2.1.0 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: fail: true - # TODO: Remove 429s exception once https://github.com/open-telemetry/opentelemetry-go-contrib/issues/6183 is resolved - args: --max-concurrency 5 --cache --max-cache-age 1d --accept 100..=103,200..=299,429 . + args: --max-concurrency 5 --cache --max-cache-age 1d --cache-exclude-status 300..=599 . diff --git a/.github/workflows/links.yml b/.github/workflows/links.yml index 1ffb4e8d2ec..e8f7bfeaeb7 100644 --- a/.github/workflows/links.yml +++ b/.github/workflows/links.yml @@ -26,12 +26,11 @@ jobs: - name: Link Checker id: lychee - uses: lycheeverse/lychee-action@v1.10.0 + uses: lycheeverse/lychee-action@v2.1.0 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: - # TODO: Remove 429s exception once https://github.com/open-telemetry/opentelemetry-go-contrib/issues/6183 is resolved - args: --max-concurrency 1 --cache --max-cache-age 1d --accept 100..=103,200..=299,429 . + args: --max-concurrency 1 --cache --max-cache-age 1d --cache-exclude-status 300..=599 . - name: Create Issue From File if: steps.lychee.outputs.exit_code != 0