Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Span decorators to Processors. Name suggestions? #538

Closed
tsloughter opened this issue Jan 14, 2023 · 2 comments
Closed

Add Span decorators to Processors. Name suggestions? #538

tsloughter opened this issue Jan 14, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@tsloughter
Copy link
Member

Per the spec we can have Span "decorators" do modify the Span in the built-in processors. This still needs to be added.

They could be used for things like adding baggage to the Span attributes instead of using a separate Span Processor.

I don't like the name "decorator" for these in Erlang/Elixir since people equate those with decorating a function, so name suggestions would be helpful.

@tsloughter tsloughter added the enhancement New feature or request label Jan 14, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Erlang backlog Jan 14, 2023
@albertored
Copy link
Contributor

Is this still valid? I don't find anything about "Span decorators" in the spec?

@tsloughter
Copy link
Member Author

Ah no, it isn't. The decorators were removed from the spec: open-telemetry/opentelemetry-specification#3363

So I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants