Validate MaxRPCMsgSize in controller config#868
Merged
christos68k merged 1 commit intoOct 23, 2025
Conversation
Contributor
Author
|
Closed
Contributor
Author
dmathieu
changed the title
MaxRPCMsgSize in controller config
dmathieu
approved these changes
Oct 23, 2025
christos68k
approved these changes
Oct 23, 2025
florianl
added a commit
that referenced
this pull request
Oct 23, 2025
Removed validation for MaxRPCMsgSize in config. The merge of #868 prevents eBPF profiler from starting: ``` ERRO[0000] invalid max-rpc-msg-size: got 0, must be greater than 0 ```
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the validation of the config of the controller.
This is a split of #859 where the goal is to implement Validate on the config without code duplication. See #849 (comment) for more context.