From d28e10689da7cf0e1740b19126bd7b195b31ea75 Mon Sep 17 00:00:00 2001 From: Christos Kalkanis Date: Fri, 27 Mar 2026 14:29:35 -0400 Subject: [PATCH 1/2] Update CONTRIBUTING with more clear review feedback handling --- CONTRIBUTING.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2a2c6bc78..dd10d064e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -86,6 +86,18 @@ All pull requests are squashed to a single commit upon merge to `main`. [`draft`](https://github.blog/2019-02-14-introducing-draft-pull-requests/). * Make sure CLA is signed and CI is clear. +### How to Address Review Feedback + +Please use the GitHub UI to accept review suggestions that you don't +subsequently modify. Do not reimplement them in a separate commit. +The latter behavior is problematic as it: + +1. Increases burden on reviewers who have to spend additional time to check + that your reimplementation accurately reflects the original suggestion. +2. Increases the probability of bugs being introduced into the codebase. + This is not a theoretical concern as we've seen it happen multiple times. +3. Does not credit the reviewer who came up with the accepted suggestion. + ### How to Get PRs Merged A PR is considered **ready to merge** when: From f52217e3fb76e8cb6d0ae92547ff6c3ed27dddee Mon Sep 17 00:00:00 2001 From: Christos Kalkanis Date: Fri, 27 Mar 2026 14:41:58 -0400 Subject: [PATCH 2/2] Minor update --- CONTRIBUTING.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index dd10d064e..130eb1a3c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -98,6 +98,13 @@ The latter behavior is problematic as it: This is not a theoretical concern as we've seen it happen multiple times. 3. Does not credit the reviewer who came up with the accepted suggestion. +You can pull the GitHub-generated commits (after you've accepted a suggestion) +into your local repository by executing: + +```sh +git pull +``` + ### How to Get PRs Merged A PR is considered **ready to merge** when: