added config template that OBI accepts#974
Conversation
|
|
|
@itsCheithanya was this written by you or generated automatically? |
|
@NimrodAvni78 I created this by referencing all the structs ,yes we should keep that in mind if any structs change we need to update here maybe give a NOTE in the structs will be a good approach? |
MrAlias
left a comment
There was a problem hiding this comment.
I would rather we use something like jsonschema or cue to validate our configuration syntax instead of adding the noise of a one-off yaml file.
|
@MrAlias Thanks for the feedback! I understand the concern about maintaining a one-off YAML file. I can refactor this to use either approach . Which would be better? also should I keep this template as documentation alongside the schema,or replace it entirely? |
|
@itsCheithanya I would suggest jsonschema as that is used in other parts of OTel including the declarative config. I would focus on just using jsonschema, no need for this yaml file. |
|
ive created a PR that generates json schema automatically from the config struct |
|
Closing in favor of #1017 |
Checklist
Fixes #973