-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpStatusCode as int instead of string #998
Merged
cijothomas
merged 8 commits into
open-telemetry:master
from
cijothomas:cijothomas/activitypreview8-part2
Aug 4, 2020
Merged
HttpStatusCode as int instead of string #998
cijothomas
merged 8 commits into
open-telemetry:master
from
cijothomas:cijothomas/activitypreview8-part2
Aug 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddynaka
approved these changes
Aug 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #998 +/- ##
==========================================
+ Coverage 68.17% 68.18% +0.01%
==========================================
Files 218 218
Lines 5973 5975 +2
Branches 974 974
==========================================
+ Hits 4072 4074 +2
Misses 1630 1630
Partials 271 271
|
…m/cijothomas/opentelemetry-dotnet into cijothomas/activitypreview8-part2
pcwiese
approved these changes
Aug 4, 2020
Ofcourse this breaks all exporters except console, as they aren't looking for activity.TagObjects :) Exporter changes are coming next. |
reyang
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #940
Part 2 of #954
Changes
HttpStatusCode in all spans attribute (http.status_code) to use int value.
Please provide a brief description of the changes here. Update the
CHANGELOG.md
for non-trivial changes.For significant contributions please make sure you have completed the following items: