From 5c64ee9c4816f8947f82b8ac6d8708faf42ec21b Mon Sep 17 00:00:00 2001 From: martincostello Date: Sat, 19 Sep 2026 09:03:49 +0100 Subject: [PATCH 1/3] [OpenTelemetry] Fix NotSupportedException Handle `NotSupportedException` when building the wildcard Regex for a large number of activity sources. Fixes #7787. --- src/OpenTelemetry/CHANGELOG.md | 5 +++++ src/OpenTelemetry/Internal/WildcardHelper.cs | 19 ++++++++++++++----- .../Internal/WildcardHelperTests.cs | 11 +++++++++++ 3 files changed, 30 insertions(+), 5 deletions(-) diff --git a/src/OpenTelemetry/CHANGELOG.md b/src/OpenTelemetry/CHANGELOG.md index b5dbe56cc3d..b860a3c2767 100644 --- a/src/OpenTelemetry/CHANGELOG.md +++ b/src/OpenTelemetry/CHANGELOG.md @@ -6,6 +6,11 @@ Notes](../../RELEASENOTES.md). ## Unreleased +* Fixed `NotSupportedException` thrown when building a `TracerProvider` or + `MeterProvider` with a large number of wildcard source/meter patterns on + `net8.0`. + ([#7788](https://github.com/open-telemetry/opentelemetry-dotnet/pull/7788)) + ## 1.19.0 Released 2026-Sep-18 diff --git a/src/OpenTelemetry/Internal/WildcardHelper.cs b/src/OpenTelemetry/Internal/WildcardHelper.cs index c3dda8d77e3..12fec0a9a9f 100644 --- a/src/OpenTelemetry/Internal/WildcardHelper.cs +++ b/src/OpenTelemetry/Internal/WildcardHelper.cs @@ -9,9 +9,7 @@ namespace OpenTelemetry; internal static class WildcardHelper { -#if !NET private static readonly TimeSpan RegexMatchTimeout = TimeSpan.FromSeconds(1); -#endif public static bool ContainsWildcard( [NotNullWhen(true)] @@ -44,10 +42,21 @@ public static Regex GetWildcardRegex(IEnumerable patterns) var pattern = "^(?:" + convertedPattern + ")$"; #if NET - return new Regex(pattern, RegexOptions.NonBacktracking | RegexOptions.IgnoreCase); -#else - return new Regex(pattern, RegexOptions.Compiled | RegexOptions.IgnoreCase, RegexMatchTimeout); + try + { + return new Regex(pattern, RegexOptions.NonBacktracking | RegexOptions.IgnoreCase); + } + catch (NotSupportedException) + { + // RegexOptions.NonBacktracking has a fixed limit on the size of the automata it can + // build (e.g., 1,000 nodes on .NET 8, larger on later versions). A very large number + // of source/meter patterns can exceed that limit and cause the constructor to throw. + // If this happens, fall back to a backtracking regex bounded by a match timeout. + // See https://github.com/open-telemetry/opentelemetry-dotnet/issues/7787. + } #endif + + return new Regex(pattern, RegexOptions.Compiled | RegexOptions.IgnoreCase, RegexMatchTimeout); } public static bool IsMatch(Regex regex, string input) diff --git a/test/OpenTelemetry.Tests/Internal/WildcardHelperTests.cs b/test/OpenTelemetry.Tests/Internal/WildcardHelperTests.cs index 30fb6d03ef8..a73fa3995be 100644 --- a/test/OpenTelemetry.Tests/Internal/WildcardHelperTests.cs +++ b/test/OpenTelemetry.Tests/Internal/WildcardHelperTests.cs @@ -23,6 +23,17 @@ public void GetWildcardRegex_DoesNotCatastrophicallyBacktrack() Assert.True(sw.Elapsed < TimeSpan.FromSeconds(5), $"Non-matching input took {sw.Elapsed.TotalSeconds:F1}s."); } + [Fact] + public void GetWildcardRegex_HandlesLargeNumberOfPatterns() + { + var patterns = Enumerable.Range(0, 300).Select(i => $"Some.Namespace.Source.{i}.*").ToArray(); + + var regex = WildcardHelper.GetWildcardRegex(patterns); + + Assert.True(WildcardHelper.IsMatch(regex, "Some.Namespace.Source.42.Foo")); + Assert.False(WildcardHelper.IsMatch(regex, "Some.Other.Namespace")); + } + [Theory] [InlineData(new[] { "a" }, "a", true)] [InlineData(new[] { "a.*" }, "a.b", true)] From 44fca8bd1b72a92548eca4c4bd6a8ac405b9d28d Mon Sep 17 00:00:00 2001 From: martincostello Date: Sat, 19 Sep 2026 14:08:19 +0100 Subject: [PATCH 2/3] [OpenTelemetry] Remove NonBacktracking `RegexOptions.NonBacktracking` causes significantly more memory for the same patterns, so rely solely on the match timeout to avoid `OutOfMemoryException` in consumers in large patterns. --- src/OpenTelemetry/CHANGELOG.md | 3 ++- src/OpenTelemetry/Internal/WildcardHelper.cs | 20 +++++-------------- .../Internal/WildcardHelperTests.cs | 18 +++++++++++++++++ 3 files changed, 25 insertions(+), 16 deletions(-) diff --git a/src/OpenTelemetry/CHANGELOG.md b/src/OpenTelemetry/CHANGELOG.md index b860a3c2767..e8377a02c59 100644 --- a/src/OpenTelemetry/CHANGELOG.md +++ b/src/OpenTelemetry/CHANGELOG.md @@ -8,7 +8,8 @@ Notes](../../RELEASENOTES.md). * Fixed `NotSupportedException` thrown when building a `TracerProvider` or `MeterProvider` with a large number of wildcard source/meter patterns on - `net8.0`. + `net8.0`, and a related `OutOfMemoryException` that could occur when many + such providers were built over the lifetime of a process. ([#7788](https://github.com/open-telemetry/opentelemetry-dotnet/pull/7788)) ## 1.19.0 diff --git a/src/OpenTelemetry/Internal/WildcardHelper.cs b/src/OpenTelemetry/Internal/WildcardHelper.cs index 12fec0a9a9f..bc2f6804064 100644 --- a/src/OpenTelemetry/Internal/WildcardHelper.cs +++ b/src/OpenTelemetry/Internal/WildcardHelper.cs @@ -41,21 +41,11 @@ public static Regex GetWildcardRegex(IEnumerable patterns) var pattern = "^(?:" + convertedPattern + ")$"; -#if NET - try - { - return new Regex(pattern, RegexOptions.NonBacktracking | RegexOptions.IgnoreCase); - } - catch (NotSupportedException) - { - // RegexOptions.NonBacktracking has a fixed limit on the size of the automata it can - // build (e.g., 1,000 nodes on .NET 8, larger on later versions). A very large number - // of source/meter patterns can exceed that limit and cause the constructor to throw. - // If this happens, fall back to a backtracking regex bounded by a match timeout. - // See https://github.com/open-telemetry/opentelemetry-dotnet/issues/7787. - } -#endif - + // RegexOptions.NonBacktracking is not used as it has a fixed automata-size limit that many + // source patterns can exceed and it retains a much larger automaton per Regex instance + // than a backtracking regex, which can lead to an OutOfMemoryException in applications. + // The match timeout bounds worst-case matching time to protect against catastrophic backtracking. + // See https://github.com/open-telemetry/opentelemetry-dotnet/issues/7787. return new Regex(pattern, RegexOptions.Compiled | RegexOptions.IgnoreCase, RegexMatchTimeout); } diff --git a/test/OpenTelemetry.Tests/Internal/WildcardHelperTests.cs b/test/OpenTelemetry.Tests/Internal/WildcardHelperTests.cs index a73fa3995be..c5c7031afbe 100644 --- a/test/OpenTelemetry.Tests/Internal/WildcardHelperTests.cs +++ b/test/OpenTelemetry.Tests/Internal/WildcardHelperTests.cs @@ -34,6 +34,24 @@ public void GetWildcardRegex_HandlesLargeNumberOfPatterns() Assert.False(WildcardHelper.IsMatch(regex, "Some.Other.Namespace")); } + [Fact] + public void GetWildcardRegex_HandlesRealWorldSourcePatternCombination() + { + var patterns = new[] + { + "SomeApplication.App", + "AWSSDK.*", + "System.Net.Http", + "OpenTelemetry.Instrumentation.AWSLambda", + }; + + var regex = WildcardHelper.GetWildcardRegex(patterns); + + Assert.True(WildcardHelper.IsMatch(regex, "SomeApplication.App")); + Assert.True(WildcardHelper.IsMatch(regex, "AWSSDK.DynamoDB")); + Assert.False(WildcardHelper.IsMatch(regex, "Unrelated.Source")); + } + [Theory] [InlineData(new[] { "a" }, "a", true)] [InlineData(new[] { "a.*" }, "a.b", true)] From 1cb15a98512e1fb4026bf2ec310a26fba883c25e Mon Sep 17 00:00:00 2001 From: martincostello Date: Sun, 20 Sep 2026 18:36:55 +0100 Subject: [PATCH 3/3] [OpenTelemetry] Extend fix Extend the same fix to views for the only other usage of `RegexOptions.NonBacktracking` too. --- .../Builder/MeterProviderBuilderExtensions.cs | 15 +++++++++------ .../Metrics/MetricViewTests.cs | 14 ++++++++++++++ 2 files changed, 23 insertions(+), 6 deletions(-) diff --git a/src/OpenTelemetry/Metrics/Builder/MeterProviderBuilderExtensions.cs b/src/OpenTelemetry/Metrics/Builder/MeterProviderBuilderExtensions.cs index f9e14d60033..cd163de44ba 100644 --- a/src/OpenTelemetry/Metrics/Builder/MeterProviderBuilderExtensions.cs +++ b/src/OpenTelemetry/Metrics/Builder/MeterProviderBuilderExtensions.cs @@ -169,16 +169,19 @@ public static MeterProviderBuilder AddView(this MeterProviderBuilder meterProvid if (instrumentName.Contains('*')) #endif { -#if NET - var pattern = '^' + Regex.Escape(instrumentName).Replace("\\*", ".*", StringComparison.Ordinal); - var regex = new Regex(pattern, RegexOptions.NonBacktracking | RegexOptions.IgnoreCase); -#elif NETSTANDARD2_1_OR_GREATER +#if NET || NETSTANDARD2_1_OR_GREATER var pattern = '^' + Regex.Escape(instrumentName).Replace("\\*", ".*", StringComparison.Ordinal); - var regex = new Regex(pattern, RegexOptions.Compiled | RegexOptions.IgnoreCase, TimeSpan.FromSeconds(1)); #else var pattern = '^' + Regex.Escape(instrumentName).Replace("\\*", ".*"); - var regex = new Regex(pattern, RegexOptions.Compiled | RegexOptions.IgnoreCase, TimeSpan.FromSeconds(1)); #endif + + // RegexOptions.NonBacktracking is not used as it retains a much larger automaton + // per Regex instance than a backtracking regex, which can lead to an + // OutOfMemoryException in applications that build many providers with wildcard + // views over their lifetime. The match timeout bounds worst-case matching time + // to protect against catastrophic backtracking. + // See https://github.com/open-telemetry/opentelemetry-dotnet/issues/7787. + var regex = new Regex(pattern, RegexOptions.Compiled | RegexOptions.IgnoreCase, TimeSpan.FromSeconds(1)); meterProviderBuilderSdk.AddView(instrument => WildcardHelper.IsMatch(regex, instrument.Name) ? metricStreamConfiguration : null); } else diff --git a/test/OpenTelemetry.Tests/Metrics/MetricViewTests.cs b/test/OpenTelemetry.Tests/Metrics/MetricViewTests.cs index 8e985530a04..a6e45d52438 100644 --- a/test/OpenTelemetry.Tests/Metrics/MetricViewTests.cs +++ b/test/OpenTelemetry.Tests/Metrics/MetricViewTests.cs @@ -112,6 +112,20 @@ public void AddViewWithNameInMetricStreamConfigurationThrowsInvalidArgumentExcep .AddInMemoryExporter(exportedItems))); } + [Fact] + public void AddViewWithLargeWildcardPatternDoesNotThrow() + { + var instrumentName = string.Concat(Enumerable.Repeat("a*", 1000)); + + var exportedItems = new List(); + + using var meter = new Meter(Utils.GetCurrentMethodName()); + using var container = BuildMeterProvider(out var meterProvider, builder => builder + .AddMeter(meter.Name) + .AddView(instrumentName, new MetricStreamConfiguration()) + .AddInMemoryExporter(exportedItems)); + } + [Fact] public void AddViewWithExceptionInUserCallbackAppliedDefault() {