[Instrumentation.SqlClient] Improve changelog #5327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@julealgon, please review if it is helpful. Similar changes as you described in EFCore package in contrib repository. |
Member
Author
|
PR for EFCore: open-telemetry/opentelemetry-dotnet-contrib#1575 @cijothomas, FYI |
cijothomas
approved these changes
Feb 7, 2024
Kielek
commented
Feb 7, 2024
julealgon
approved these changes
Feb 7, 2024
rajkumar-rangaraj
approved these changes
Feb 7, 2024
utpilla
reviewed
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/opentelemetry-dotnet-contrib#1559 (comment)
Design discussion issue #
Changes
Better changelog entry
Merge requirement checklist
[ ] Unit tests added/updatedCHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)