Skip to content

Conversation

@Kielek
Copy link
Member

@Kielek Kielek commented Jan 29, 2024

Fixes # N/A
Design discussion issue # N/A
Similiar pr for GrpcNetClient #5259

Changes

Drop support for old semantic convention in SqlClient instrumenation

Notes

MD-lint check is failing. Not related to these changes. Tracked under: #5271

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (6250307) 83.38% compared to head (b4bef13) 82.58%.
Report is 42 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5270      +/-   ##
==========================================
- Coverage   83.38%   82.58%   -0.80%     
==========================================
  Files         297      272      -25     
  Lines       12531    11957     -574     
==========================================
- Hits        10449     9875     -574     
  Misses       2082     2082              
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 24.66% <39.68%> (?)
unittests-Instrumentation-Stable 24.66% <39.68%> (?)
unittests-Solution-Experimental 82.93% <74.07%> (?)
unittests-Solution-Stable 82.59% <74.07%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
....Api/Context/Propagation/TraceContextPropagator.cs 88.88% <100.00%> (-0.59%) ⬇️
...etryProtocol/Implementation/ExperimentalOptions.cs 100.00% <ø> (ø)
...tation/OpenTelemetryProtocolExporterEventSource.cs 100.00% <100.00%> (ø)
...rotocol/Implementation/OtlpLogRecordTransformer.cs 93.45% <100.00%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs 89.79% <100.00%> (+0.21%) ⬆️
...AspNetCore/Implementation/HttpInMetricsListener.cs 89.74% <100.00%> (+0.26%) ⬆️
....GrpcNetClient/GrpcClientInstrumentationOptions.cs 100.00% <ø> (+25.00%) ⬆️
...ent/Implementation/GrpcClientDiagnosticListener.cs 75.80% <100.00%> (-2.77%) ⬇️
...n.GrpcNetClient/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...plementation/HttpWebRequestActivitySource.netfx.cs 80.16% <100.00%> (-0.62%) ⬇️
... and 9 more

... and 45 files with indirect coverage changes

@Kielek Kielek force-pushed the instrumentation-sql-only-new-network-convention branch from 06b9efd to d0c904d Compare January 29, 2024 07:18
@Kielek Kielek marked this pull request as ready for review January 29, 2024 07:28
@Kielek Kielek requested a review from a team January 29, 2024 07:28
@alanwest alanwest merged commit edc9fe2 into open-telemetry:main Jan 30, 2024
@Kielek Kielek deleted the instrumentation-sql-only-new-network-convention branch January 30, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants