-
Notifications
You must be signed in to change notification settings - Fork 857
[AOT] Fix RuntimeContext warnings #4460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
87cfa2a
initial commit
Yun-Ting bf8a530
Merge branch 'main' into yunl/runtimeContextEnum
Yun-Ting b133982
add custom type
Yun-Ting 236a5f1
CI
Yun-Ting d4c38af
update
Yun-Ting bd2d709
update
Yun-Ting db04bd1
update
Yun-Ting 260327b
fix sanity check
Yun-Ting 6be9d0c
format
Yun-Ting 5dae942
static ctor
Yun-Ting ebee07a
added support for ReflectionRuntimeContextSlotFactory
Yun-Ting 299fc2a
sanity
Yun-Ting e93903f
Merge branch 'main' into yunl/runtimeContextEnum
Yun-Ting cc00b30
test CI
Yun-Ting 99c8baa
Revert "test CI"
Yun-Ting a773917
CI
Yun-Ting fc32b25
update
Yun-Ting 6ef81cd
Merge branch 'yunl/runtimeContextEnum' of https://github.com/Yun-Ting…
Yun-Ting 23b77b5
comment
Yun-Ting 6faf599
update
Yun-Ting e6b016c
ci
Yun-Ting 44bb210
CI
Yun-Ting 8d76270
preprossesor
Yun-Ting 05bb4b6
fix build
Yun-Ting 8586200
Add the trimming attributes to only OpenTelemetry.Api, and use #if to…
eerhardt 452f6a6
CI
Yun-Ting 649e39d
Adjust the folder path to the attributes.
eerhardt f0c7f44
CI
Yun-Ting f8714f9
Fix nullable warning in LoggerProviderSdk
eerhardt 7956ab1
CI
Yun-Ting d2024a8
address comments
Yun-Ting b9c0b33
sanity check
Yun-Ting 4120ffb
fix test
Yun-Ting 633da1b
indentation
Yun-Ting 7c1fde4
increased timeout and removed RS0026
Yun-Ting 48d0b7f
RS0026
Yun-Ting 19fce6a
CI
Yun-Ting 35173c8
Fix ApiCompat for OpenTelemetry.Api's net6.0 target.
eerhardt 21495bc
CI
Yun-Ting 586511d
Merge branch 'main' into yunl/runtimeContextEnum
eerhardt 9ba6626
fixed merge; scope down suppresion of RS0026
Yun-Ting File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
src/OpenTelemetry.Api/Context/RuntimeContextSlotFactory.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // <copyright file="RuntimeContextSlotFactory.cs" company="OpenTelemetry Authors"> | ||
| // Copyright The OpenTelemetry Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // </copyright> | ||
|
|
||
| #nullable enable | ||
|
|
||
| namespace OpenTelemetry.Context | ||
| { | ||
| internal abstract class RuntimeContextSlotFactory | ||
| { | ||
| public abstract RuntimeContextSlot<T> Create<T>(string name); | ||
|
|
||
| public sealed class AsyncLocalRuntimeContextSlotFactory : RuntimeContextSlotFactory | ||
| { | ||
| public override RuntimeContextSlot<T> Create<T>(string name) | ||
| => new AsyncLocalRuntimeContextSlot<T>(name); | ||
| } | ||
|
|
||
| #if NETFRAMEWORK | ||
| public sealed class RemotingRuntimeContextSlotFactory : RuntimeContextSlotFactory | ||
| { | ||
| public override RuntimeContextSlot<T> Create<T>(string name) | ||
| => new RemotingRuntimeContextSlot<T>(name); | ||
| } | ||
| #endif | ||
|
|
||
| public sealed class ThreadLocalRuntimeContextSlotFactory : RuntimeContextSlotFactory | ||
| { | ||
| public override RuntimeContextSlot<T> Create<T>(string name) | ||
| => new ThreadLocalRuntimeContextSlot<T>(name); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.