Skip to content

Conversation

@TimothyMothra
Copy link

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@TimothyMothra TimothyMothra requested a review from a team November 22, 2022 23:04
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #3933 (74d7963) into main (a2c1926) will decrease coverage by 2.16%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3933      +/-   ##
==========================================
- Coverage   87.41%   85.24%   -2.17%     
==========================================
  Files         278      287       +9     
  Lines       10747    11026     +279     
==========================================
+ Hits         9394     9399       +5     
- Misses       1353     1627     +274     
Impacted Files Coverage Δ
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 73.52% <0.00%> (-8.83%) ⬇️
...lemetry.Exporter.Console/ConsoleExporterOptions.cs 0.00% <0.00%> (ø)
...xporter.Console/ConsoleExporterHelperExtensions.cs 0.00% <0.00%> (ø)
...porter.Console/ConsoleExporterLoggingExtensions.cs 0.00% <0.00%> (ø)
...emetry.Exporter.Console/ConsoleActivityExporter.cs 0.00% <0.00%> (ø)
...elemetry.Exporter.Console/ConsoleTagTransformer.cs 0.00% <0.00%> (ø)
.../OpenTelemetry.Exporter.Console/ConsoleExporter.cs 0.00% <0.00%> (ø)
...porter.Console/ConsoleExporterMetricsExtensions.cs 0.00% <0.00%> (ø)
...metry.Exporter.Console/ConsoleLogRecordExporter.cs 0.00% <0.00%> (ø)
...elemetry.Exporter.Console/ConsoleMetricExporter.cs 0.00% <0.00%> (ø)
... and 4 more

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimothyMothra
Copy link
Author

TimothyMothra commented Nov 22, 2022

I think these are flaky tests...

docfx:

[22-11-22 11:37:58.091]Error:[BuildCore.Build Document.CompilePhaseHandlerWithIncremental.ConceptualDocumentProcessor.Build.BuildConceptualDocument](src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md)Markup failed: Index was outside the bounds of the array..

Integration Tests: w3c-trace-context-test:

tests_1  | [xUnit.net 00:00:01.70]     OpenTelemetry.Instrumentation.W3cTraceContext.Tests.W3CTraceContextTests.W3CTraceContextTestSuiteAsync(value: "placeholder") [FAIL]
tests_1  |   Failed OpenTelemetry.Instrumentation.W3cTraceContext.Tests.W3CTraceContextTests.W3CTraceContextTestSuiteAsync(value: "placeholder") [930 ms]
tests_1  |   Error Message:
tests_1  |    Assert.StartsWith() Failure:
tests_1  | Expected: FAILED (failures=2)
tests_1  | Actual:   FAILED (failures=2,...

Edit:

Updating docfx in #3937
Updating W3CTraceContextTests in #3938

@utpilla utpilla merged commit 39283c7 into open-telemetry:main Nov 24, 2022
@TimothyMothra TimothyMothra deleted the consoletestproject branch November 24, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants