-
Notifications
You must be signed in to change notification settings - Fork 857
create empty test project for Console Exporter #3933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
utpilla
merged 6 commits into
open-telemetry:main
from
TimothyMothra:consoletestproject
Nov 24, 2022
Merged
create empty test project for Console Exporter #3933
utpilla
merged 6 commits into
open-telemetry:main
from
TimothyMothra:consoletestproject
Nov 24, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
CodeBlanch
reviewed
Nov 22, 2022
test/OpenTelemetry.Exporter.Console.Tests/OpenTelemetry.Exporter.Console.Tests.csproj
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3933 +/- ##
==========================================
- Coverage 87.41% 85.24% -2.17%
==========================================
Files 278 287 +9
Lines 10747 11026 +279
==========================================
+ Hits 9394 9399 +5
- Misses 1353 1627 +274
|
CodeBlanch
approved these changes
Nov 22, 2022
Member
CodeBlanch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Author
|
I think these are flaky tests... docfx: Integration Tests: w3c-trace-context-test: Edit: Updating docfx in #3937 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I'm adding new tests in another PR: Fix ConsoleExporter fails silently when exporting an
ActivityLinkwithout Tags. #3932Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes