From 10cfe34994576097f16a8329a693ad5c88587e45 Mon Sep 17 00:00:00 2001 From: Cijo Thomas Date: Tue, 1 Mar 2022 10:41:08 -0800 Subject: [PATCH] Example app to enable httpclient metrics instrumentation --- examples/AspNetCore/Startup.cs | 1 + .../Implementation/HttpHandlerMetricsDiagnosticListener.cs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/AspNetCore/Startup.cs b/examples/AspNetCore/Startup.cs index 88199d052d7..9a60cd3b092 100644 --- a/examples/AspNetCore/Startup.cs +++ b/examples/AspNetCore/Startup.cs @@ -124,6 +124,7 @@ public void ConfigureServices(IServiceCollection services) services.AddOpenTelemetryMetrics(builder => { builder.AddAspNetCoreInstrumentation(); + builder.AddHttpClientInstrumentation(); switch (metricsExporter) { diff --git a/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerMetricsDiagnosticListener.cs b/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerMetricsDiagnosticListener.cs index 2fa58e88b1c..44ef0d8d0fb 100644 --- a/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerMetricsDiagnosticListener.cs +++ b/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerMetricsDiagnosticListener.cs @@ -30,7 +30,7 @@ internal class HttpHandlerMetricsDiagnosticListener : ListenerHandler public HttpHandlerMetricsDiagnosticListener(string name, Meter meter) : base(name) { - this.httpClientDuration = meter.CreateHistogram("http.client.duration", "milliseconds", "measure the duration of the outbound HTTP request"); + this.httpClientDuration = meter.CreateHistogram("http.client.duration", "ms", "measures the duration of the outbound HTTP request"); } public override void OnStopActivity(Activity activity, object payload)