-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor exporter - step 5 #1087
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1087 +/- ##
==========================================
- Coverage 76.17% 76.01% -0.16%
==========================================
Files 225 225
Lines 6199 6208 +9
==========================================
- Hits 4722 4719 -3
- Misses 1477 1489 +12
|
It is probably more .NET-y to use |
I've updated the names. Please take a look. Initially I was thinking to use these abstract names to unify the queue/process/exporter (e.g. queue would have |
This is a follow up PR of #1078.
Changes
Ingress
andEgress
internal properties to the circular buffer, which would be useful for internal logging.BatchExportActivityProcessor
.For significant contributions please make sure you have completed the following items: