Skip to content

Commit eb12f9b

Browse files
authored
Console exporter: Display exponential histogram boundaries (#4507)
1 parent 47d88e1 commit eb12f9b

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

src/OpenTelemetry.Exporter.Console/ConsoleMetricExporter.cs

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,21 @@ public override ExportResult Export(in Batch<Metric> batch)
146146
}
147147
else
148148
{
149-
// TODO: Consider how/if to display buckets for exponential histograms.
150-
bucketsBuilder.AppendLine("Buckets are not displayed for exponential histograms.");
149+
var exponentialHistogramData = metricPoint.GetExponentialHistogramData();
150+
var scale = exponentialHistogramData.Scale;
151+
152+
if (exponentialHistogramData.ZeroCount != 0)
153+
{
154+
bucketsBuilder.AppendLine($"Zero Bucket:{exponentialHistogramData.ZeroCount}");
155+
}
156+
157+
var offset = exponentialHistogramData.PositiveBuckets.Offset;
158+
foreach (var bucketCount in exponentialHistogramData.PositiveBuckets)
159+
{
160+
var lowerBound = Base2ExponentialBucketHistogram.LowerBoundary(offset, scale).ToString(CultureInfo.InvariantCulture);
161+
var upperBound = Base2ExponentialBucketHistogram.LowerBoundary(++offset, scale).ToString(CultureInfo.InvariantCulture);
162+
bucketsBuilder.AppendLine($"({lowerBound}, {upperBound}]:{bucketCount}");
163+
}
151164
}
152165

153166
valueDisplay = bucketsBuilder.ToString();

src/OpenTelemetry.Exporter.Console/OpenTelemetry.Exporter.Console.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
<Compile Include="$(RepoRoot)\src\OpenTelemetry\Internal\OpenTelemetrySdkEventSource.cs" Link="Includes\OpenTelemetrySdkEventSource.cs" />
2929
<Compile Include="$(RepoRoot)\src\OpenTelemetry\Internal\PeriodicExportingMetricReaderHelper.cs" Link="Includes\PeriodicExportingMetricReaderHelper.cs" />
3030
<Compile Include="$(RepoRoot)\src\OpenTelemetry\Internal\TagTransformer.cs" Link="Includes\TagTransformer.cs" />
31+
<Compile Include="$(RepoRoot)\src\OpenTelemetry\Metrics\Base2ExponentialBucketHistogram.LowerBoundary.cs" Link="Includes\Base2ExponentialBucketHistogram.LowerBoundary.cs" />
3132
<Compile Include="$(RepoRoot)\src\OpenTelemetry.Api\Internal\ExceptionExtensions.cs" Link="Includes\ExceptionExtensions.cs" />
3233
<Compile Include="$(RepoRoot)\src\OpenTelemetry.Api\Internal\Guard.cs" Link="Includes\Guard.cs" />
3334
<Compile Include="$(RepoRoot)\src\OpenTelemetry.Api\Internal\SpanAttributeConstants.cs" Link="Includes\SpanAttributeConstants.cs" />

0 commit comments

Comments
 (0)