Example app to enable httpclient metrics instrumentation (#2955)

cijothomas · web-flow · commit b6dcfe8e09af · 2022-03-01T11:21:40.000-08:00
diff --git a/examples/AspNetCore/Startup.cs b/examples/AspNetCore/Startup.cs
@@ -124,6 +124,7 @@ public void ConfigureServices(IServiceCollection services)
             services.AddOpenTelemetryMetrics(builder =>
             {
                 builder.AddAspNetCoreInstrumentation();
+                builder.AddHttpClientInstrumentation();
 
                 switch (metricsExporter)
                 {
diff --git a/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerMetricsDiagnosticListener.cs b/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerMetricsDiagnosticListener.cs
@@ -30,7 +30,7 @@ internal class HttpHandlerMetricsDiagnosticListener : ListenerHandler
         public HttpHandlerMetricsDiagnosticListener(string name, Meter meter)
             : base(name)
         {
-            this.httpClientDuration = meter.CreateHistogram<double>("http.client.duration", "milliseconds", "measure the duration of the outbound HTTP request");
+            this.httpClientDuration = meter.CreateHistogram<double>("http.client.duration", "ms", "measures the duration of the outbound HTTP request");
         }
 
         public override void OnStopActivity(Activity activity, object payload)

Original file line number	Diff line number	Diff line change
`@@ -124,6 +124,7 @@ public void ConfigureServices(IServiceCollection services)`
`124`	`124`	`services.AddOpenTelemetryMetrics(builder =>`
`125`	`125`	`{`
`126`	`126`	`builder.AddAspNetCoreInstrumentation();`
	`127`	`+ builder.AddHttpClientInstrumentation();`
`127`	`128`
`128`	`129`	`switch (metricsExporter)`
`129`	`130`	`{`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ internal class HttpHandlerMetricsDiagnosticListener : ListenerHandler`
`30`	`30`	`public HttpHandlerMetricsDiagnosticListener(string name, Meter meter)`
`31`	`31`	`: base(name)`
`32`	`32`	`{`
`33`		`- this.httpClientDuration = meter.CreateHistogram<double>("http.client.duration", "milliseconds", "measure the duration of the outbound HTTP request");`
	`33`	`+ this.httpClientDuration = meter.CreateHistogram<double>("http.client.duration", "ms", "measures the duration of the outbound HTTP request");`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`public override void OnStopActivity(Activity activity, object payload)`