Skip to content

Commit 8b88f43

Browse files
alanwestutpilla
andauthored
[GrpcNetClient] Clarify impact to SuppressDownstreamInstrumentation (#5340)
Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
1 parent a2f85dc commit 8b88f43

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

src/OpenTelemetry.Instrumentation.GrpcNetClient/CHANGELOG.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,15 @@
66

77
Released 2024-Feb-09
88

9-
* **Breaking Change** :
9+
* **Breaking Change**:
10+
Please be advised that the
1011
[SuppressDownstreamInstrumentation](https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Instrumentation.GrpcNetClient#suppressdownstreaminstrumentation)
11-
option will no longer be supported when used with certain versions of
12-
`OpenTelemetry.Instrumentation.Http` package. Check out this
12+
option no longer works when used in conjunction with the
13+
`OpenTelemetry.Instrumentation.Http` package version `1.6.0` or greater.
14+
This is not a result of a change in the `OpenTelemetry.Instrumentation.GrpcNetClient`
15+
package therefore this also affects versions prior to this release. See this
1316
[issue](https://github.com/open-telemetry/opentelemetry-dotnet/issues/5092)
1417
for details and workaround.
15-
([#5077](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5077))
1618
* Removed support for the `OTEL_SEMCONV_STABILITY_OPT_IN` environment variable
1719
which toggled the use of the new conventions for the
1820
[server, client, and shared network attributes](https://github.com/open-telemetry/semantic-conventions/blob/v1.23.0/docs/general/attributes.md#server-client-and-shared-network-attributes).

src/OpenTelemetry.Instrumentation.GrpcNetClient/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,11 @@ This instrumentation can be configured to change the default behavior by using
8080

8181
### SuppressDownstreamInstrumentation
8282

83+
> [!CAUTION]
84+
> `SuppressDownstreamInstrumentation` no longer works when used in conjunction
85+
with the `OpenTelemetry.Instrumentation.Http` package version `1.6.0` and greater.
86+
This option may change or even be removed in a future release.
87+
8388
This option prevents downstream instrumentation from being invoked.
8489
Grpc.Net.Client is built on top of HttpClient. When instrumentation for both
8590
libraries is enabled, `SuppressDownstreamInstrumentation` prevents the

0 commit comments

Comments
 (0)