Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@theletterf - documentation codeowner #1275

Merged
merged 3 commits into from
Sep 28, 2022
Merged

@theletterf - documentation codeowner #1275

merged 3 commits into from
Sep 28, 2022

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Sep 26, 2022

Why & What

Automatically inform @theletterf about changes in documentation.

For now, we do not have documentation team, we can create it if we find more people.

@theletterf is OTel member.

Based on configuration from https://github.com/open-telemetry/opentelemetry-dotnet-contrib

Tests

N/A

Checklist

  • [ ] CHANGELOG.md is updated.
  • [ ] Documentation is updated.
  • [ ] New features are covered by tests.

@Kielek Kielek requested review from a team and theletterf September 26, 2022 07:18
@Kielek Kielek marked this pull request as draft September 26, 2022 07:44
@Kielek Kielek marked this pull request as ready for review September 26, 2022 10:43
@pellared pellared changed the title @theletterf - docuemntation codeowner @theletterf - documentation codeowner Sep 26, 2022
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/workflows/assign-reviewers.yml Show resolved Hide resolved
@@ -0,0 +1,16 @@
name: 'Assign Reviewers'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test this workflow on a fork (or maybe even here by making some simple change in .md file)?

Take notice that in this repo by default GITHUB_TOKEN has only read permissions for the contents scope.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was needed #1287

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Kielek Kielek marked this pull request as draft September 26, 2022 18:32
@Kielek
Copy link
Contributor Author

Kielek commented Sep 26, 2022

I will fix it tommorow, sorry guys...

@Kielek Kielek requested a review from pellared September 27, 2022 06:35
@Kielek Kielek marked this pull request as ready for review September 27, 2022 06:35
@pjanotti pjanotti merged commit b6c3465 into open-telemetry:main Sep 28, 2022
@pjanotti
Copy link
Contributor

@Kielek it is merged, could you please create a PR to validate if it is working as intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants