Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GraphQL instrumentation to match the proposed semantic conventions #494

Closed
nrcventura opened this issue Apr 15, 2022 · 0 comments · Fixed by #1222
Closed

Update GraphQL instrumentation to match the proposed semantic conventions #494

nrcventura opened this issue Apr 15, 2022 · 0 comments · Fixed by #1222
Assignees
@RassK
Milestone
0.4.0-beta

Comments

@nrcventura
Copy link
Member

Semantic conventions are currently being proposed for GraphQL. The GraphQL instrumentation should be updated to follow that proposal.

Current differences include:

  • The span name
  • Span attribute names
  • Current instrumentation has more attributes than what is defined in the proposed conventions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RassK RassK

Labels
None yet
Projects
OpenTelemetry .NET Automatic Instrumentation
Archived in project
Milestone
0.4.0-beta
Development

Successfully merging a pull request may close this issue.

Update GraphQL semantics RassK/opentelemetry-dotnet-instrumentation
4 participants
@RassK @pellared @pjanotti @nrcventura