Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry.Exporter.Geneva 1.4.0-beta.4 requires OpenTelemetry (= 1.4.0-beta.2) #780

Closed
1 of 2 tasks
abatishchev opened this issue Nov 18, 2022 · 2 comments
Closed
1 of 2 tasks
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva

Comments

@abatishchev
Copy link
Contributor

Issue with OpenTelemetry.Exporter.Geneva

Given

results in a warning:

 warning NU1608: Detected package version outside of dependency constraint: OpenTelemetry.Exporter.Geneva 1.4.0-beta.4 requires OpenTelemetry (= 1.4.0-beta.2) but version OpenTelemetry 1.4.0-beta.3 was resolved.

Because according to NuGet it has strict requirement on the certain version:

<dependencies>
  <group targetFramework=".NETFramework4.6.2">
    <dependency id="OpenTelemetry" version="[1.4.0-beta.2]" exclude="Build,Analyzers" />
  </group>
  <group targetFramework=".NETStandard2.0">
    <dependency id="OpenTelemetry" version="[1.4.0-beta.2]" exclude="Build,Analyzers" />
  </group>
</dependencies>

Runtime information (which doesn't matter):

<PropertyGroup>
  <TargetFramework>net7.0</TargetFramework>
  <Platform>AnyCPU</Platform>
</PropertyGroup>

Is this a feature request or a bug?

  • Feature Request
  • Bug

What is the expected behavior?

Please either:

  • Release a version of OpenTelemetry.Exporter.Geneva built against the latest OpenTelemetry (=1.4.0-beta4)
  • Relax the version requirements to >=

What is the actual behavior?

No warning is produced.

@abatishchev abatishchev added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Nov 18, 2022
@Kielek
Copy link
Contributor

Kielek commented Nov 18, 2022

It is expected. Please check this comment: #774 (comment).

What is more, all changes needed to work with 1.4.0-beta.3 are in place. You can request release by preparing PR siimilar to: #777

More details how to make a release request: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/CONTRIBUTING.md#how-to-request-for-release-of-package

EDIT: In this case new Geneva package version should be 1.4.0-beta.4

@cijothomas
Copy link
Member

Echo what @Kielek said. It is intentional to have specific version dependency. The dependency is a non-stable package, and can introduce breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

No branches or pull requests

3 participants