Move string literals to AWS Semnatic Conventions class

Author: ppittle

src/OpenTelemetry.Resources.AWS/AWSEBSDetector.cs

@@ -56,9 +56,9 @@ internal static List<KeyValuePair<string, object>> ExtractResourceAttributes(AWS
     {
         var resourceAttributes = new List<KeyValuePair<string, object>>()
         {
-            new(AWSSemanticConventions.AttributeCloudProvider, "aws"),
-            new(AWSSemanticConventions.AttributeCloudPlatform, "aws_elastic_beanstalk"),
-            new(AWSSemanticConventions.AttributeServiceName, "aws_elastic_beanstalk"),
+            new(AWSSemanticConventions.AttributeCloudProvider, AWSSemanticConventions.CloudProviderValuesAws),
+            new(AWSSemanticConventions.AttributeCloudPlatform, AWSSemanticConventions.CloudPlatformValuesAwsElasticBeanstalk),
+            new(AWSSemanticConventions.AttributeServiceName, AWSSemanticConventions.ServiceNameValuesAwsElasticBeanstalk),
         };
 
         if (metadata != null)

src/OpenTelemetry.Resources.AWS/AWSEC2Detector.cs

@@ -45,8 +45,8 @@ internal static List<KeyValuePair<string, object>> ExtractResourceAttributes(AWS
     {
         var resourceAttributes = new List<KeyValuePair<string, object>>()
         {
-            new(AWSSemanticConventions.AttributeCloudProvider, "aws"),
-            new(AWSSemanticConventions.AttributeCloudPlatform, "aws_ec2"),
+            new(AWSSemanticConventions.AttributeCloudProvider, AWSSemanticConventions.CloudProviderValuesAws),
+            new(AWSSemanticConventions.AttributeCloudPlatform, AWSSemanticConventions.CloudPlatformValuesAwsEc2),
             new(AWSSemanticConventions.AttributeHostName, hostName),
         };
 

src/OpenTelemetry.Resources.AWS/AWSECSDetector.cs

@@ -29,8 +29,8 @@ public Resource Detect()
 
         var resourceAttributes = new List<KeyValuePair<string, object>>()
         {
-            new(AWSSemanticConventions.AttributeCloudProvider, "aws"),
-            new(AWSSemanticConventions.AttributeCloudPlatform, "aws_ecs"),
+            new(AWSSemanticConventions.AttributeCloudProvider, AWSSemanticConventions.CloudProviderValuesAws),
+            new(AWSSemanticConventions.AttributeCloudPlatform, AWSSemanticConventions.CloudPlatformValuesAwsEcs),
         };
 
         try

src/OpenTelemetry.Resources.AWS/AWSEKSDetector.cs

@@ -38,8 +38,8 @@ internal static List<KeyValuePair<string, object>> ExtractResourceAttributes(str
     {
         var resourceAttributes = new List<KeyValuePair<string, object>>()
         {
-            new(AWSSemanticConventions.AttributeCloudProvider, "aws"),
-            new(AWSSemanticConventions.AttributeCloudPlatform, "aws_eks"),
+            new(AWSSemanticConventions.AttributeCloudProvider, AWSSemanticConventions.CloudProviderValuesAws),
+            new(AWSSemanticConventions.AttributeCloudPlatform, AWSSemanticConventions.CloudPlatformValuesAwsEks),
         };
 
         if (!string.IsNullOrEmpty(clusterName))

src/OpenTelemetry.Resources.AWS/AWSSemanticConventions.cs

@@ -11,6 +11,11 @@ internal static class AWSSemanticConventions
     public const string AttributeCloudProvider = "cloud.provider";
     public const string AttributeCloudRegion = "cloud.region";
     public const string AttributeCloudResourceId = "cloud.resource_id";
+    public const string CloudPlatformValuesAwsEc2 = "aws_ec2";
+    public const string CloudPlatformValuesAwsEcs = "aws_ecs";
+    public const string CloudPlatformValuesAwsEks = "aws_eks";
+    public const string CloudPlatformValuesAwsElasticBeanstalk = "aws_elastic_beanstalk";
+    public const string CloudProviderValuesAws = "aws";
 
     public const string AttributeContainerID = "container.id";