diff --git a/CHANGELOG.md b/CHANGELOG.md index 310d8ac962..06a9575ee0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,9 @@ Increment the: * [CONFIGURATION] File configuration - implement log_level [#3810](https://github.com/open-telemetry/opentelemetry-cpp/pull/3810) +* [SEMANTIC CONVENTIONS] Upgrade to semantic conventions 1.39.0 + [#3813](https://github.com/open-telemetry/opentelemetry-cpp/pull/3813) + Breaking changes: * [CONFIGURATION] File configuration - remove zipkin diff --git a/api/include/opentelemetry/semconv/db_attributes.h b/api/include/opentelemetry/semconv/db_attributes.h index fa77366619..67abc8a669 100644 --- a/api/include/opentelemetry/semconv/db_attributes.h +++ b/api/include/opentelemetry/semconv/db_attributes.h @@ -84,7 +84,7 @@ static constexpr const char *kDbOperationName = "db.operation.name"; Summary may be available to the instrumentation through instrumentation hooks or other means. If it is not available, instrumentations that support query parsing SHOULD generate a summary following - Generating query + Generating query summary section. */ static constexpr const char *kDbQuerySummary = "db.query.summary"; @@ -92,11 +92,10 @@ static constexpr const char *kDbQuerySummary = "db.query.summary"; /** The database query being executed.

- For sanitization see Sanitization of @code - db.query.text @endcode. For batch operations, if the individual operations are known to have - the same query text then that query text SHOULD be used, otherwise all of the individual query - texts SHOULD be concatenated with separator @code ; @endcode or some other database system + For sanitization see Sanitization + of @code db.query.text @endcode. For batch operations, if the individual operations are known + to have the same query text then that query text SHOULD be used, otherwise all of the individual + query texts SHOULD be concatenated with separator @code ; @endcode or some other database system specific separator if more applicable. Parameterized query text SHOULD NOT be sanitized. Even though parameterized query text can potentially have sensitive data, by using a parameterized query the user is giving a strong signal that any sensitive data will be passed as parameter diff --git a/api/include/opentelemetry/semconv/error_attributes.h b/api/include/opentelemetry/semconv/error_attributes.h index e0ef3c925e..427a515347 100644 --- a/api/include/opentelemetry/semconv/error_attributes.h +++ b/api/include/opentelemetry/semconv/error_attributes.h @@ -35,7 +35,7 @@ namespace error additional filters are applied.

If the operation has completed successfully, instrumentations SHOULD NOT set @code error.type - @endcode.

If a specific domain defines its own set of error identifiers (such as HTTP or gRPC + @endcode.

If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes), it's RECOMMENDED to: