New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root span is not sampled correctly #782

Closed

HonghuiLu2021 opened this issue May 21, 2021 · 0 comments · Fixed by #784

Assignees

Labels

bug

HonghuiLu2021 commented May 21, 2021

TraceIdRatioBasedSampler always samples the root span because TraceId==0 when the sampling decision is made in the C++ version of StartSpan.

To fix, for root spans, a TraceId should be generated before calling ShouldSample, e.g. in the Java SDK.

HonghuiLu2021 added the bug label

lalitb mentioned this issue

fix for sampling root span #784

Merged

3 tasks

ThomsonTan assigned lalitb

lalitb closed this as completed in #784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment