Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraceFlags is not propagated from parent span span to child span #602

Closed
ThomsonTan opened this issue Mar 9, 2021 · 0 comments · Fixed by #603
Closed

TraceFlags is not propagated from parent span span to child span #602

ThomsonTan opened this issue Mar 9, 2021 · 0 comments · Fixed by #603
Assignees
@ThomsonTan
Labels
bug Something isn't working
Milestone
1.0.0-rc.1

Comments

@ThomsonTan
Copy link
Contributor

When creating new Span with parent span context passed, we ignore the trace flags from the parent span context and always pass 0, see below code snippet. This blocks propagation of sampled status from parent span to child span.

opentelemetry-cpp/sdk/src/trace/span.cc

Line 97 in 58a1e8c

new trace_api::SpanContext(trace_id, span_id, trace_api::TraceFlags(), false,

@ThomsonTan ThomsonTan added the bug Something isn't working label Mar 9, 2021
@ThomsonTan ThomsonTan self-assigned this Mar 9, 2021
@ThomsonTan ThomsonTan mentioned this issue Mar 9, 2021
Merged
3 tasks
@lalitb lalitb added this to the 1.0.0-rc.1 milestone Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomsonTan ThomsonTan

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-rc.1
Development

Successfully merging a pull request may close this issue.

Propagate trace_flags from parent span to child span ThomsonTan/opentelemetry-cpp
2 participants
@ThomsonTan @lalitb