OpenTelemetry's cmake file claims to publish OPENTELEMETRY_CPP_FOUND/etc. but really publishes OPENTELEMETRY-CPP_FOUND - with a dash.

[niande-xbox]

Describe your environment
Users of this library will look at the CMAKE file cmake/opentelemetry-cpp-config.cmake.in (as did opentelemetry-cpp-contrib and try to use that target, but if you print CMAKE variables, you'll see that the _FOUND variable actually has the dash, which makes sense if you look at the find_package_handle_standard_args call at the bottom of this file.

Steps to reproduce
Print the CMAKE variables after running find_package(opentelemetry-cpp CONFIG QUIET), and you'll see: -- opentelemetry-cpp_FOUND=1 not -- opentelemetry_cpp_FOUND=1.

What is the expected behavior?
The documented CMAKE variables (which have an underscore rather than a dash) should match the actual CMAKE variables (with are with dashes).

What is the actual behavior?
They do not match.

Additional context
This leads to other dependent repos failing to include opentelemetry-cpp correctly.

[lalitb]

Thanks for reporting. We can probably document it here with a snippet - https://github.com/open-telemetry/opentelemetry-cpp/blob/main/INSTALL.md#incorporating-into-an-existing-cmake-project. And fix the naming here -

opentelemetry-cpp/cmake/opentelemetry-cpp-config.cmake.in

Line 21 in 049ab63

# OPENTELEMETRY_CPP_FOUND - True if opentelemetry-cpp found.

[owent]

The <package name>_FOUND is generated by cmake automatically, it's not always OPENTELEMETRY-CPP_FOUND , but may be opentelemetry-cpp_FOUND when we use find_package(opentelemetry-cpp) . I think we can add a alias of <package name>_FOUND which named OPENTELEMETRY_CPP_FOUND .