-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zipkin example is not compiled successfully due to missing header file error #2068
Comments
This is surprising, because in the [CI] builds, the zipkin exporter example builds properly. Below is a log taken from the clang 14 (maintainer mode) build.
Please clarify how the build is done (with the cmake commands used), and paste the compiler error message seen. |
Current CMake version is 3.25.1 In our project, OTLP as a third-party library (v1.8.3) that will be compiled & linked into our application. In our CMakeLists.txt file, OTLP options are configued like this: set(WITH_STL OFF)
set(WITH_EXAMPLES ON)
set(WITH_ZIPKIN ON)
set(WITH_OTLP ON)
set(WITH_OTLP_GRPC ON)
set(USE_NLOHMANN_JSON OFF)
set(BUILD_TESTING OFF) Afterwards, when we compile the examples, getting this error during compilation:
|
Thanks for the details. Approved the PR. |
Describe your environment
When "WITH_ZIPKIN" option is ON while compile Zipkin example, compiler complains about that "opentelemetry/exporters/zipkin/zipkin_exporter_factory.h" file not found.
Steps to reproduce
set(WITH_EXAMPLES ON)
set(WITH_ZIPKIN ON)
What is the expected behavior?
Zipkin example should be compiled successfully when its example is enabled.
What is the actual behavior?
Compiler error due to not found header file.
Additional context
Zipkin folder inside of "exporters" folder there is a CMakefile of this component. In this CMakefile, target_include_directories was not defined. In my opinion, this is a problem that needs to be fixed.
The text was updated successfully, but these errors were encountered: