Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support handling Retryable error for OTLP exporter (OTLP/gRPC and OTLP/HTTP) #2049

Open
mks26 opened this issue Mar 14, 2023 · 3 comments · May be fixed by #3219 or #3223
Open

Support handling Retryable error for OTLP exporter (OTLP/gRPC and OTLP/HTTP) #2049

mks26 opened this issue Mar 14, 2023 · 3 comments · May be fixed by #3219 or #3223
Labels
area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter do-not-stale help wanted Good for taking. Extra help will be provided by maintainers

Comments

@mks26
Copy link

mks26 commented Mar 14, 2023

Hi,

If OTel collector is down or due to some other reason if OTLP exporter received Retryable error code from OTel collector, it has to be handled and the OTLP exporter has to retry sending the same trace span. Currently there is no code in OTLP exporter(both OTLP/gRPC and OTLP/HTTP) to handle retryable error code in opentelmetry-cpp sdk. As currently retryable error code is not handled for OTLP exporters, so it will discard the trace span when OTel collector returned retryable error code).

Error codes that are retryable and non-retryable is mentioned in OTLP spec at :
https://opentelemetry.io/docs/reference/specification/protocol/otlp/

OTLP/GRPC: https://opentelemetry.io/docs/reference/specification/protocol/otlp/#failures
OTLP/HTTP : https://opentelemetry.io/docs/reference/specification/protocol/otlp/#failures-1

I this this can be a candidate for feature.

discussion link: #2042

Thanks,
Mukesh

@lalitb
Copy link
Member

lalitb commented Mar 14, 2023

Thanks for raising the issue. Just to add, the support for handling retryable/non-retryable response from OTLP collector is marked as optional feature in the specs - https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md#exporters. Which means, this won't be of high priority, will mark this as help required if someone wants to contribute it.

@lalitb lalitb added help wanted Good for taking. Extra help will be provided by maintainers area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter labels Mar 14, 2023
@mks26
Copy link
Author

mks26 commented Mar 20, 2023

Thanks @lalitb !

@github-actions
Copy link

This issue was marked as stale due to lack of activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter do-not-stale help wanted Good for taking. Extra help will be provided by maintainers
Projects
None yet
2 participants