-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ubuntu-18.04 runner image dependency from CI pipeline. #2019
Comments
This explains the failure in CI with GCC 4.8:
|
Do we really need GCC 4.8, or just to compile with C++11 ? How about compiling with a more recent GCC (available on Ubuntu 20.04), with -std=c++11 instead of the default ? |
I remember GCC 4.8 is still used by @owent . |
There is special handling in the code for some of the scenarios where GCC 4.8 fails with it's C++11 support (regex being one of them). But yeah, if it's not easy to use GCC 4.8 over ubuntu 20.04, we can switch to -std=c++11. Let me give it a try :) |
ubunu-18.04 runner images won't be supported from April 1st 2023 as mentioned here - actions/runner-images#6002.
ubuntu-18.04 is used in CI for testing the otel-cpp builds with GCC 4.8 compiler (the initial GCC compiler with C++11 support). As we won't have C++11 support dropped before April, it would be better to upgrade the CI pipeline. The quick fix would be to upgrade to Ubuntu 20.04, and work around the lack of GCC 4.8 by manually adding the package repositories from Xenial.
The text was updated successfully, but these errors were encountered: