Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ubuntu-18.04 runner image dependency from CI pipeline. #2019

Closed
lalitb opened this issue Mar 6, 2023 · 4 comments · Fixed by #2023
Closed

Remove ubuntu-18.04 runner image dependency from CI pipeline. #2019

lalitb opened this issue Mar 6, 2023 · 4 comments · Fixed by #2023
Assignees
Labels
bug Something isn't working

Comments

@lalitb
Copy link
Member

lalitb commented Mar 6, 2023

ubunu-18.04 runner images won't be supported from April 1st 2023 as mentioned here - actions/runner-images#6002.

ubuntu-18.04 is used in CI for testing the otel-cpp builds with GCC 4.8 compiler (the initial GCC compiler with C++11 support). As we won't have C++11 support dropped before April, it would be better to upgrade the CI pipeline. The quick fix would be to upgrade to Ubuntu 20.04, and work around the lack of GCC 4.8 by manually adding the package repositories from Xenial.

@lalitb lalitb added the bug Something isn't working label Mar 6, 2023
@lalitb lalitb self-assigned this Mar 6, 2023
@marcalff
Copy link
Member

marcalff commented Mar 6, 2023

This explains the failure in CI with GCC 4.8:

To raise awareness of the upcoming removal, we will temporarily fail jobs using Ubuntu 18.04. Builds that are scheduled to run during the brownout periods will fail.

@marcalff
Copy link
Member

marcalff commented Mar 6, 2023

The quick fix would be to upgrade to Ubuntu 20.04, and work around the lack of GCC 4.8 by manually adding the package repositories from Xenial.

Do we really need GCC 4.8, or just to compile with C++11 ?

How about compiling with a more recent GCC (available on Ubuntu 20.04), with -std=c++11 instead of the default ?

@ThomsonTan
Copy link
Contributor

The quick fix would be to upgrade to Ubuntu 20.04, and work around the lack of GCC 4.8 by manually adding the package repositories from Xenial.

Do we really need GCC 4.8, or just to compile with C++11 ?

How about compiling with a more recent GCC (available on Ubuntu 20.04), with -std=c++11 instead of the default ?

I remember GCC 4.8 is still used by @owent .
#1830 (comment)

@lalitb
Copy link
Member Author

lalitb commented Mar 7, 2023

Do we really need GCC 4.8, or just to compile with C++11 ?

There is special handling in the code for some of the scenarios where GCC 4.8 fails with it's C++11 support (regex being one of them). But yeah, if it's not easy to use GCC 4.8 over ubuntu 20.04, we can switch to -std=c++11. Let me give it a try :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants