Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs SDK] OTLP Log Exporter - Populate Instrumentation Scope attributes #2008

Closed
lalitb opened this issue Feb 28, 2023 · 0 comments · Fixed by #2004
Closed

[Logs SDK] OTLP Log Exporter - Populate Instrumentation Scope attributes #2008

lalitb opened this issue Feb 28, 2023 · 0 comments · Fixed by #2004
Assignees

Comments

@lalitb
Copy link
Member

lalitb commented Feb 28, 2023

Dependent on #1690

OTLP Exporter should populate InstrumentationScope attributes from OtlpRecordable to the proto buffer. Currently it populates name and version.

Reference:

output_scope_log->mutable_scope()->set_name(input_scope_log.first->GetName());
output_scope_log->mutable_scope()->set_version(input_scope_log.first->GetVersion());

https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/common/v1/common.proto#LL71-L77

// InstrumentationScope is a message representing the instrumentation scope information
// such as the fully qualified name and version. 
message InstrumentationScope {
  // An empty instrumentation scope name means the name is unknown.
  string name = 1;
  string version = 2;
  repeated KeyValue attributes = 3;
  uint32 dropped_attributes_count = 4;
}
@lalitb lalitb changed the title [Logs SDK] OTLP Log Exporter - Populate Instrumentation Scope attributes and URL [Logs SDK] OTLP Log Exporter - Populate Instrumentation Scope attributes Feb 28, 2023
@lalitb lalitb added this to the Logs post GA release milestone Feb 28, 2023
@owent owent self-assigned this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants