Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TranslateToPrometheusHistogramNormal test fails with "Assertion failed: cannot increment end list iterator" #1956

Closed
malkia opened this issue Feb 6, 2023 · 2 comments · Fixed by #2006
Assignees
Labels
bug Something isn't working

Comments

@malkia
Copy link

malkia commented Feb 6, 2023

This is in debug only, where Microsoft STL does more checks than usual.

Steps to repro:

bazel test -c dbg //exporters/prometheus:prometheus_exporter_utils_test --test_output=streamed

gives

Executing tests from //exporters/prometheus:prometheus_exporter_utils_test
-----------------------------------------------------------------------------
Running main() from gmock_main.cc
[==========] Running 4 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 4 tests from PrometheusExporterUtils
[ RUN      ] PrometheusExporterUtils.TranslateToPrometheusEmptyInputReturnsEmptyCollection
[       OK ] PrometheusExporterUtils.TranslateToPrometheusEmptyInputReturnsEmptyCollection (0 ms)
[ RUN      ] PrometheusExporterUtils.TranslateToPrometheusIntegerCounter
[       OK ] PrometheusExporterUtils.TranslateToPrometheusIntegerCounter (0 ms)
[ RUN      ] PrometheusExporterUtils.TranslateToPrometheusIntegerLastValue
[       OK ] PrometheusExporterUtils.TranslateToPrometheusIntegerLastValue (0 ms)
[ RUN      ] PrometheusExporterUtils.TranslateToPrometheusHistogramNormal
C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include\list(162) : Assertion failed: cannot increment end list iterator

I've fixed in my own repo - malkia@974ec51

@malkia malkia added the bug Something isn't working label Feb 6, 2023
@lalitb lalitb self-assigned this Feb 8, 2023
@esigo esigo self-assigned this Feb 8, 2023
@esigo
Copy link
Member

esigo commented Feb 8, 2023

@malkia thanks for reaching out to us. Your change looks valid. Would you like to raise a PR?
Thanks

@malkia
Copy link
Author

malkia commented Feb 10, 2023

@malkia thanks for reaching out to us. Your change looks valid. Would you like to raise a PR? Thanks

I wish, but my branch has many other changes (a "dll" branch), when I have time I can try setup a new one with just this (and few other fixes in the future). Though not sure if CLA/etc. needs to be filled. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants