Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run metrics_ostream_example separately in bazel.asan/tsan? #1952

Closed
ThomsonTan opened this issue Feb 3, 2023 · 1 comment · Fixed by #2030
Closed

Run metrics_ostream_example separately in bazel.asan/tsan? #1952

ThomsonTan opened this issue Feb 3, 2023 · 1 comment · Fixed by #2030
Assignees
@ThomsonTan
Labels
bug Something isn't working

Comments

@ThomsonTan
Copy link
Contributor

In below CI script, we run metrics_ostream_example separately after bazel run. Is this necessary or can be removed?

opentelemetry-cpp/ci/do_ci.sh

Line 296 in d56a5c7

//examples/metrics_simple:metrics_ostream_example > /dev/null

@ThomsonTan ThomsonTan added the bug Something isn't working label Feb 3, 2023
@lalitb
Copy link
Member

lalitb commented Feb 3, 2023

This was added as part of this issue - #1669, seems for some race conditions which were not reproducible through unit-tests. I think can be removed, now that we don't have the issue anymore.

@ThomsonTan ThomsonTan mentioned this issue Mar 8, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomsonTan ThomsonTan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] Remove separate run of metrics ostream example ThomsonTan/opentelemetry-cpp
2 participants
@ThomsonTan @lalitb