Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoggerContext::Shutdown should call processor_->Shutdown, not processor_->ForceFlush . #1591

Closed
owent opened this issue Sep 5, 2022 · 0 comments · Fixed by #1592
Closed

LoggerContext::Shutdown should call processor_->Shutdown, not processor_->ForceFlush . #1591

owent opened this issue Sep 5, 2022 · 0 comments · Fixed by #1592
Assignees
@owent
Labels
bug Something isn't working

Comments

@owent
Copy link
Member

owent commented Sep 5, 2022 •
edited
Loading

Describe your environment
Any
Opentelemetry-cpp: v1.6.0

What is the expected behavior?
LoggerContext::Shutdown should call processor_->Shutdown .

What is the actual behavior?
LoggerContext::Shutdown calls processor_->ForceFlush .
@owent owent added the bug Something isn't working label Sep 5, 2022
@owent owent self-assigned this Sep 5, 2022
@owent owent changed the title LoggerProvider::Shutdown should call LoggerContext::Shutdown, not LoggerContext::ForceFlush . LoggerContext::Shutdown should call processor_->Shutdown, not processor_->ForceFlush . Sep 5, 2022
@owent owent mentioned this issue Sep 5, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owent owent

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix LoggerContext::Shutdown and tsan of OtlpHttpClient owent/opentelemetry-cpp
1 participant
@owent