Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InstrumentationScope and deprecate InstrumentationLibrary #1381

Closed
lalitb opened this issue May 7, 2022 · 1 comment · Fixed by #1469
Closed

Add InstrumentationScope and deprecate InstrumentationLibrary #1381

lalitb opened this issue May 7, 2022 · 1 comment · Fixed by #1469
Labels
spec-compliance Not compliant to OpenTelemetry specs

Comments

@lalitb
Copy link
Member

lalitb commented May 7, 2022

This spec PR open-telemetry/opentelemetry-specification#2276 introduced the concept of InstrumentationScope.

The support needs to be added without breaking the existing API for Traces. We may need to introduce another TracerProvider::GetTracer() method to add InstrumentationScope and ensure both InstrumentationLibrary and InstrumentationScope are propagated to exporters.
@lalitb lalitb added the spec-compliance Not compliant to OpenTelemetry specs label May 7, 2022
@lalitb lalitb mentioned this issue May 7, 2022
Closed
@lalitb
Copy link
Member Author

lalitb commented Jun 22, 2022 •
edited
Loading

Seems otel-proto is removing the deprecated InstrumentationLibrary from schema - https://github.com/open-telemetry/opentelemetry-proto/pull/407/files

Which means we would be able to upgrade to latest otel-proto only once this issue is fixed.

@ThomsonTan ThomsonTan mentioned this issue Jun 29, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec-compliance Not compliant to OpenTelemetry specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove reference to deprecated InstrumentationLibrary in OTLP ThomsonTan/opentelemetry-cpp
1 participant
@lalitb