Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark tests as part of the CI #1170

Closed
esigo opened this issue Jan 9, 2022 · 4 comments · Fixed by #1174
Closed

benchmark tests as part of the CI #1170

esigo opened this issue Jan 9, 2022 · 4 comments · Fixed by #1174
Assignees

Comments

@esigo
Copy link
Member

esigo commented Jan 9, 2022

Is your feature request related to a problem?
It is hard to overstate the importance of benchmarking and monitoring the benchmarks over time. This becomes even more important to us as it is expected/desired that telemetry operations should have minimal adverse impact on performance. In order to quantify and measure how well we're doing there, benchmark tests have to be added as part of the CI.

Describe the solution you'd like

This can be done using continuous-benchmark where benchmark results can be stored on every merge to the main branch. To avoid noising the main branch, gh-pages branch can be used to push the benchmark results. This has already been used in python SIG.

Tasks which require privilege:

  • Activating githbub-pages
  • Creating gh-pages branch

Describe alternatives you've considered
Which alternative solutions or features have you considered?

Additional context
Add any other context about the feature request here.

@esigo
Copy link
Member Author

esigo commented Jan 9, 2022

This can be assigned to me.

@esigo
Copy link
Member Author

esigo commented Jan 9, 2022

The graphs for the benchmark tests we already have in the repo can be found here

@lalitb
Copy link
Member

lalitb commented Jan 12, 2022

Please see if this is what is required:

gh-pages

@esigo
Copy link
Member Author

esigo commented Jan 12, 2022

Thanks @lalitb, yes it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants