Skip to content

Commit d299348

Browse files
authored
Fix code scanning alert (#1530)
1 parent b4d8245 commit d299348

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

ext/test/http/curl_http_test.cc

+3-3
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ TEST_F(BasicCurlHttpTests, SendGetRequestSyncTimeout)
329329
curl::HttpClientSync http_client;
330330

331331
http_client::Headers m1 = {};
332-
auto result = http_client.Get("http://222.222.222.200:19000/get/", m1);
332+
auto result = http_client.Get("https://192.0.2.0:19000/get/", m1);
333333
EXPECT_EQ(result, false);
334334

335335
// When network is under proxy, it may connect success but closed by peer when send data
@@ -415,7 +415,7 @@ TEST_F(BasicCurlHttpTests, SendGetRequestAsyncTimeout)
415415
std::shared_ptr<GetEventHandler> handlers[batch_count];
416416
for (unsigned i = 0; i < batch_count; ++i)
417417
{
418-
sessions[i] = http_client.CreateSession("http://222.222.222.200:19000/get/");
418+
sessions[i] = http_client.CreateSession("https://192.0.2.0:19000/get/");
419419
auto request = sessions[i]->CreateRequest();
420420
request->SetMethod(http_client::Method::Get);
421421
request->SetUri("get/");
@@ -426,7 +426,7 @@ TEST_F(BasicCurlHttpTests, SendGetRequestAsyncTimeout)
426426
// Lock mtx_requests to prevent response, we will check IsSessionActive() in the end
427427
std::unique_lock<std::mutex> lock_requests(mtx_requests);
428428
sessions[i]->SendRequest(handlers[i]);
429-
ASSERT_TRUE(sessions[i]->IsSessionActive());
429+
ASSERT_TRUE(sessions[i]->IsSessionActive() || handlers[i]->is_called_);
430430
}
431431

432432
for (unsigned i = 0; i < batch_count; ++i)

0 commit comments

Comments
 (0)