Skip to content

Commit

Permalink
[Doc] Cleanup ENABLE_METRICS_PREVIEW (#1745)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcalff authored Nov 8, 2022
1 parent 34b6597 commit b89f981
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 69 deletions.
13 changes: 4 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,10 @@ The C++ [OpenTelemetry](https://opentelemetry.io/) client.
| Signal | Status | Project |
| ------- | ----------------------- | ------------------------------------------------------------------------ |
| Traces | Public Release | N/A |
| Metrics | Public Release [1] | N/A |
| Logs | Experimental [2] | [Release Milestone](https://github.com/open-telemetry/opentelemetry-cpp/milestone/18)|

* [1]: The older metrics implementation (based on old
specification) is now deprecated, and would be removed soon.
This can be included in build by setting
`ENABLE_METRICS_PREVIEW` preprocessor macro, and is included under
`*/_metrics/*` directory.
* [2]: The current Log Signal Implementation is Experimental, and will change as
| Metrics | Public Release | N/A |
| Logs | Experimental [1] | [Release Milestone](https://github.com/open-telemetry/opentelemetry-cpp/milestone/18)|

* [1]: The current Log Signal Implementation is Experimental, and will change as
the current OpenTelemetry Log specification matures. The current
implementation can be included in build by setting `ENABLE_LOGS_PREVIEW`
preprocessor macro.
Expand Down
1 change: 0 additions & 1 deletion exporters/ostream/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ install(
DIRECTORY include/opentelemetry/exporters/ostream
DESTINATION include/opentelemetry/exporters
PATTERN "*.h"
PATTERN "metrics_exporter.h" EXCLUDE
PATTERN "log_Exporter.h" EXCLUDE)

if(BUILD_TESTING)
Expand Down
59 changes: 0 additions & 59 deletions exporters/ostream/src/metrics_exporter.cc

This file was deleted.

2 comments on commit b89f981

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: b89f981 Previous: 34b6597 Ratio
BM_SpinLockThrashing/2/process_time/real_time 1.3824350693646599 ms/iter 0.28157671657177286 ms/iter 4.91
BM_ProcYieldSpinLockThrashing/2/process_time/real_time 1.0236986752214103 ms/iter 0.2933816122688396 ms/iter 3.49
BM_NaiveSpinLockThrashing/2/process_time/real_time 0.9580543546965627 ms/iter 0.2963187255503692 ms/iter 3.23

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: b89f981 Previous: 34b6597 Ratio
BM_BaselineBuffer/2 4437555.551528931 ns/iter 1355591.7739868164 ns/iter 3.27
BM_BaselineBuffer/4 11806380.74874878 ns/iter 5128064.155578613 ns/iter 2.30

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.