From b0f27a465e899f79480644ba9afa24b152cbcf2c Mon Sep 17 00:00:00 2001 From: Max Golovanov Date: Fri, 16 Apr 2021 02:49:40 -0700 Subject: [PATCH] More vs2019 minor warnings cleanup (#675) --- api/include/opentelemetry/context/context.h | 2 +- api/include/opentelemetry/context/runtime_context.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/api/include/opentelemetry/context/context.h b/api/include/opentelemetry/context/context.h index 59dcd8cb11..4d3384e288 100644 --- a/api/include/opentelemetry/context/context.h +++ b/api/include/opentelemetry/context/context.h @@ -140,7 +140,7 @@ class Context next_ = nostd::shared_ptr{nullptr}; } - DataList &operator=(DataList &&other) + DataList &operator=(DataList &&other) noexcept { key_length_ = other.key_length_; value_ = std::move(other.value_); diff --git a/api/include/opentelemetry/context/runtime_context.h b/api/include/opentelemetry/context/runtime_context.h index 36ed7cc3cc..d9c5b0f7b4 100644 --- a/api/include/opentelemetry/context/runtime_context.h +++ b/api/include/opentelemetry/context/runtime_context.h @@ -58,6 +58,8 @@ class RuntimeContextStorage */ virtual bool Detach(Token &token) noexcept = 0; + virtual ~RuntimeContextStorage(){}; + protected: nostd::unique_ptr CreateToken(const Context &context) noexcept {