Skip to content

Commit 9f52cff

Browse files
committed
add test for empty resource
1 parent acdcc9c commit 9f52cff

File tree

1 file changed

+21
-2
lines changed

1 file changed

+21
-2
lines changed

sdk/test/resource/resource_test.cc

+21-2
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ TEST(ResourceTest, create_without_servicename)
5454

5555
TEST(ResourceTest, create_with_servicename)
5656
{
57-
5857
opentelemetry::sdk::resource::ResourceAttributes expected_attributes = {
5958
{"version", (uint32_t)1},
6059
{"cost", 234.23},
@@ -63,7 +62,6 @@ TEST(ResourceTest, create_with_servicename)
6362
{"telemetry.sdk.version", OPENTELEMETRY_SDK_VERSION},
6463
{"service.name", "backend"},
6564
};
66-
6765
opentelemetry::sdk::resource::ResourceAttributes attributes = {
6866
{"service.name", "backend"}, {"version", (uint32_t)1}, {"cost", 234.23}};
6967
auto resource = opentelemetry::sdk::resource::Resource::Create(attributes);
@@ -85,6 +83,26 @@ TEST(ResourceTest, create_with_servicename)
8583
EXPECT_EQ(received_attributes.size(), expected_attributes.size()); // for missing service.name
8684
}
8785

86+
TEST(ResourceTest, create_with_emptyatrributes)
87+
{
88+
opentelemetry::sdk::resource::ResourceAttributes expected_attributes = {
89+
{"telemetry.sdk.language", "cpp"},
90+
{"telemetry.sdk.name", "opentelemetry"},
91+
{"telemetry.sdk.version", OPENTELEMETRY_SDK_VERSION},
92+
{"service.name", "unknown_service"},
93+
};
94+
opentelemetry::sdk::resource::ResourceAttributes attributes = {};
95+
auto resource = opentelemetry::sdk::resource::Resource::Create(attributes);
96+
auto received_attributes = resource.GetAttributes();
97+
for (auto &e : received_attributes)
98+
{
99+
EXPECT_TRUE(expected_attributes.find(e.first) != expected_attributes.end());
100+
if (expected_attributes.find(e.first) != expected_attributes.end())
101+
EXPECT_EQ(opentelemetry::nostd::get<std::string>(expected_attributes.find(e.first)->second),
102+
opentelemetry::nostd::get<std::string>(e.second));
103+
}
104+
EXPECT_EQ(received_attributes.size(), expected_attributes.size()); // for missing service.name
105+
}
88106
TEST(ResourceTest, Merge)
89107
{
90108
TestResource resource1(
@@ -105,6 +123,7 @@ TEST(ResourceTest, Merge)
105123
}
106124
EXPECT_EQ(received_attributes.size(), expected_attributes.size());
107125
}
126+
108127
TEST(ResourceTest, MergeEmptyString)
109128
{
110129
TestResource resource1({{"service", "backend"}, {"host", "service-host"}});

0 commit comments

Comments
 (0)