Skip to content

Commit 904b15c

Browse files
committed
Fix -DgRPC_ABSL_PROVIDER=package
Signed-off-by: owent <[email protected]>
1 parent 44be320 commit 904b15c

File tree

2 files changed

+27
-17
lines changed

2 files changed

+27
-17
lines changed

.github/workflows/ci.yml

+1-3
Original file line numberDiff line numberDiff line change
@@ -407,9 +407,7 @@ jobs:
407407
env:
408408
WITH_ABSEIL: 'ON'
409409
run: |
410-
sudo ./ci/setup_grpc.sh -r v1.54.2 -- \
411-
"-DgRPC_ABSL_PROVIDER=package" \
412-
"-DgRPC_PROTOBUF_PROVIDER=package"
410+
sudo ./ci/setup_grpc.sh -r v1.54.2 -p protobuf -p abseil-cpp
413411
./ci/do_ci.sh cmake.exporter.otprotocol.test
414412
415413
cmake_do_not_install_test:

ci/setup_grpc.sh

+26-14
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,26 @@ std_version='14'
1212
install_grpc_version=${new_grpc_version}
1313
install_dir='/usr/local/'
1414
build_shared_libs=''
15+
build_internal_abseil_cpp=1
16+
GRPC_BUILD_OPTIONS=()
1517
usage() { echo "Usage: $0 [-v <gcc-version>] [-i <install_dir>"] 1>&2; exit 1;}
1618

17-
while getopts ":v:i:r:s:TH-" o; do
19+
while getopts ":v:i:p:r:s:TH" o; do
1820
case "${o}" in
1921
v)
2022
gcc_version=${OPTARG}
2123
;;
2224
i)
2325
install_dir=${OPTARG}
2426
;;
27+
p)
28+
if [[ "${OPTARG}" == "protobuf" ]]; then
29+
GRPC_BUILD_OPTIONS=(${GRPC_BUILD_OPTIONS[@]} "-DgRPC_PROTOBUF_PROVIDER=package")
30+
elif [[ "${OPTARG}" == "abseil-cpp" ]]; then
31+
GRPC_BUILD_OPTIONS=(${GRPC_BUILD_OPTIONS[@]} "-DgRPC_ABSL_PROVIDER=package")
32+
build_internal_abseil_cpp=0
33+
fi
34+
;;
2535
r)
2636
install_grpc_version=${OPTARG}
2737
;;
@@ -34,8 +44,6 @@ while getopts ":v:i:r:s:TH-" o; do
3444
H)
3545
build_shared_libs="ON"
3646
;;
37-
-)
38-
break
3947
;;
4048
*)
4149
usage
@@ -65,22 +73,26 @@ git clone --depth=1 -b ${install_grpc_version} https://github.com/grpc/grpc
6573
pushd grpc
6674
git submodule init
6775
git submodule update --depth 1
68-
mkdir -p "third_party/abseil-cpp/build" && pushd "third_party/abseil-cpp/build"
69-
set -x
7076

71-
ABSEIL_CPP_BUILD_OPTIONS=(
72-
-DCMAKE_BUILD_TYPE=Release
73-
-DCMAKE_POSITION_INDEPENDENT_CODE=TRUE
74-
-DCMAKE_INSTALL_PREFIX=$INSTALL_DIR
75-
)
76-
if [ ! -z "$build_shared_libs" ]; then
77-
ABSEIL_CPP_BUILD_OPTIONS=(${ABSEIL_CPP_BUILD_OPTIONS[@]} "-DBUILD_SHARED_LIBS=$build_shared_libs")
77+
if [[ $build_internal_abseil_cpp -ne 0 ]]; then
78+
mkdir -p "third_party/abseil-cpp/build" && pushd "third_party/abseil-cpp/build"
79+
set -x
80+
81+
ABSEIL_CPP_BUILD_OPTIONS=(
82+
-DCMAKE_BUILD_TYPE=Release
83+
-DCMAKE_POSITION_INDEPENDENT_CODE=TRUE
84+
-DCMAKE_INSTALL_PREFIX=$INSTALL_DIR
85+
)
86+
if [ ! -z "$build_shared_libs" ]; then
87+
ABSEIL_CPP_BUILD_OPTIONS=(${ABSEIL_CPP_BUILD_OPTIONS[@]} "-DBUILD_SHARED_LIBS=$build_shared_libs")
88+
fi
89+
cmake ${ABSEIL_CPP_BUILD_OPTIONS[@]} ..
90+
cmake --build . -j${nproc} --target install && popd
7891
fi
79-
cmake ${ABSEIL_CPP_BUILD_OPTIONS[@]} ..
80-
cmake --build . -j${nproc} --target install && popd
8192
mkdir -p build && pushd build
8293

8394
GRPC_BUILD_OPTIONS=(
95+
${GRPC_BUILD_OPTIONS[@]}
8496
-DgRPC_INSTALL=ON
8597
-DCMAKE_CXX_STANDARD=${std_version}
8698
-DgRPC_BUILD_TESTS=OFF

0 commit comments

Comments
 (0)