Skip to content

Commit 7196ec3

Browse files
authored
[CI] Benchmark workflow fails, C++14 required to build grpc (#2278)
1 parent 628838a commit 7196ec3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/benchmark.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@ jobs:
2525
key: bazel_benchmark
2626
- name: setup
2727
run: |
28-
sudo -E ./ci/setup_cmake.sh
29-
sudo -E ./ci/setup_ci_environment.sh
28+
sudo ./ci/setup_ci_environment.sh
29+
sudo ./ci/install_bazelisk.sh
3030
- name: Run benchmark
3131
id: run_benchmarks
3232
run: |
33-
CC=/usr/bin/gcc-10 CXX=/usr/bin/g++-10 ci/do_ci.sh bazel.benchmark
33+
./ci/do_ci.sh bazel.benchmark
3434
mkdir -p benchmarks
3535
mv api-benchmark_result.json benchmarks
3636
mv sdk-benchmark_result.json benchmarks

ci/do_ci.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ function run_benchmarks
2525

2626
[ -z "${BENCHMARK_DIR}" ] && export BENCHMARK_DIR=$HOME/benchmark
2727
mkdir -p $BENCHMARK_DIR
28-
bazel $BAZEL_STARTUP_OPTIONS build --cxxopt=-std=c++14 $BAZEL_OPTIONS_ASYNC -c opt -- \
28+
bazel $BAZEL_STARTUP_OPTIONS build --host_cxxopt=-std=c++14 --cxxopt=-std=c++14 $BAZEL_OPTIONS_ASYNC -c opt -- \
2929
$(bazel query 'attr("tags", "benchmark_result", ...)')
3030
echo ""
3131
echo "Benchmark results in $BENCHMARK_DIR:"

0 commit comments

Comments
 (0)