stream: update stream configuration to include/exclude #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows open-telemetry/opentelemetry-specification#4188 to add support to exclude attribute keys from stream configuration. Signed-off-by: Alex Boten <[email protected]>
|
Will mark ready for review once the spec change is merged |
Closed
|
spec has merged, this is now ready for review |
jack-berg
reviewed
Sep 18, 2024
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
jack-berg
reviewed
Sep 18, 2024
examples/kitchen-sink.yaml
Outdated
| @@ -262,6 +262,7 @@ meter_provider: | |||
| included: | |||
| - key1 | |||
| - key2 | |||
| # Configure resource attributes to be excluded, in this example attribute service.attr1. | |||
There was a problem hiding this comment.
Suggested change
| # Configure resource attributes to be excluded, in this example attribute service.attr1. | |
| # Configure resource attributes to be excluded, in this example attribute key3. |
This brings up a good point. It seems like this needs to be either a list to include, OR a list to exclude, but not both?
There was a problem hiding this comment.
Does it? I would expect this to be similar to how resource attributes can be included or excluded. The example in the kitchen sink shows an include of service.* and an exclude of service.attr1
There was a problem hiding this comment.
Not sure how SDKs would handle the presence of both include and exclude lists. I know java (and probably go) can handle.
jack-berg
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows open-telemetry/opentelemetry-specification#4188 to add support to exclude attribute keys from stream configuration.
Fixes #112