Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should attribute_keys in stream configuration support exclude lists? #112

Closed
codeboten opened this issue Aug 19, 2024 · 0 comments · Fixed by #118
Closed

Should attribute_keys in stream configuration support exclude lists? #112

codeboten opened this issue Aug 19, 2024 · 0 comments · Fixed by #118
Assignees
@codeboten
Labels
blocked:spec The issue is blocked on having spec language on the topic.

Comments

@codeboten
Copy link
Contributor

This is a follow up to #98, specifically around adding support for an exclude list. The original issue will be fixed by adding support for include/exclude options to the attribute_keys list.

This issue will remain open until a change is approved or not in the specification
@codeboten codeboten added the blocked:spec The issue is blocked on having spec language on the topic. label Aug 19, 2024
@codeboten codeboten self-assigned this Aug 19, 2024
codeboten added a commit to codeboten/opentelemetry-specification that referenced this issue Aug 19, 2024
@codeboten
Add support for filtering attribute keys for streams via an exclude list
1a954d7 
This change adds details around supporting the creation of a stream with
a set of excluded attribute keys. This is already done in the Go implementation
and the proposal in this PR is to address an issue in the configuration
working group: open-telemetry/opentelemetry-configuration#112

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten mentioned this issue Aug 19, 2024
Merged
3 tasks
jack-berg pushed a commit to open-telemetry/opentelemetry-specification that referenced this issue Sep 18, 2024
@codeboten
Add support for filtering attribute keys for streams via an exclude l…
ed85e12 
…ist (#4188)

## Changes

This change adds details around supporting the creation of a stream with
a set of excluded attribute keys. This functionality is supported in the
[Go
implementation](https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/metric/instrument.go#L146)
via the use of filters. The proposal in this PR is to address an issue
in the configuration working group:
open-telemetry/opentelemetry-configuration#112

Please provide a brief description of the changes here.

For non-trivial changes, follow the [change proposal
process](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#proposing-a-change).

* [x] Links to the prototypes (when adding or changing features) 
* [x]
[`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md)
file updated for non-trivial changes
* [x]
[`spec-compliance-matrix.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md)
updated if necessary

---------

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten mentioned this issue Sep 18, 2024
Merged
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@codeboten
Add support for filtering attribute keys for streams via an exclude l…
400e7ee 
…ist (open-telemetry#4188)

## Changes

This change adds details around supporting the creation of a stream with
a set of excluded attribute keys. This functionality is supported in the
[Go
implementation](https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/metric/instrument.go#L146)
via the use of filters. The proposal in this PR is to address an issue
in the configuration working group:
open-telemetry/opentelemetry-configuration#112

Please provide a brief description of the changes here.

For non-trivial changes, follow the [change proposal
process](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#proposing-a-change).

* [x] Links to the prototypes (when adding or changing features) 
* [x]
[`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md)
file updated for non-trivial changes
* [x]
[`spec-compliance-matrix.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md)
updated if necessary

---------

Signed-off-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
blocked:spec The issue is blocked on having spec language on the topic.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stream: update stream configuration to include/exclude codeboten/opentelemetry-configuration
1 participant
@codeboten