From 2b0646b52f54cffd572981c07fdc6b14032030c6 Mon Sep 17 00:00:00 2001 From: Pablo Baeyens Date: Tue, 9 Sep 2025 17:55:51 +0200 Subject: [PATCH 1/2] [exporterhelper] Deprecate RequestErrorHandler and RequestSizer --- .chloggen/mx-psi_requests-remove-methods.yaml | 25 +++++++++++++++++++ exporter/exporterhelper/request.go | 2 ++ 2 files changed, 27 insertions(+) create mode 100644 .chloggen/mx-psi_requests-remove-methods.yaml diff --git a/.chloggen/mx-psi_requests-remove-methods.yaml b/.chloggen/mx-psi_requests-remove-methods.yaml new file mode 100644 index 000000000000..997ae9968e29 --- /dev/null +++ b/.chloggen/mx-psi_requests-remove-methods.yaml @@ -0,0 +1,25 @@ +# Use this changelog template to create an entry for release notes. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: deprecation + +# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver) +component: exporterhelper + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: Deprecate exporterhelper.RequestErrorHandler and exporterhelper.RequestSizer + +# One or more tracking issues or pull requests related to the change +issues: [13804] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: + +# Optional: The change log or logs in which this entry should be included. +# e.g. '[user]' or '[user, api]' +# Include 'user' if the change is relevant to end users. +# Include 'api' if there is a change to a library API. +# Default: '[user]' +change_logs: [api] diff --git a/exporter/exporterhelper/request.go b/exporter/exporterhelper/request.go index a0064f40cc2c..852e2de787ad 100644 --- a/exporter/exporterhelper/request.go +++ b/exporter/exporterhelper/request.go @@ -15,6 +15,7 @@ import ( // until https://github.com/open-telemetry/opentelemetry-collector/issues/8122 is resolved. type Request = request.Request +// Deprecated [v0.136.0]: will be removed in the next minor version. // RequestErrorHandler is an optional interface that can be implemented by Request to provide a way handle partial // temporary failures. For example, if some items failed to process and can be retried, this interface allows to // return a new Request that contains the items left to be sent. Otherwise, the original Request should be returned. @@ -32,6 +33,7 @@ type RequestConverterFunc[T any] func(context.Context, T) (Request, error) // and accessing it is considered undefined behavior. type RequestConsumeFunc = sender.SendFunc[Request] +// Deprecated [v0.136.0]: will be removed in the next minor version. // RequestSizer is an interface that returns the size of the given request. type RequestSizer = request.Sizer[Request] From 51488b0aa10527a7404af82d15428d3d7cb88a70 Mon Sep 17 00:00:00 2001 From: Pablo Baeyens Date: Wed, 10 Sep 2025 13:41:16 +0200 Subject: [PATCH 2/2] Do not deprecate RequestErrorHandler --- .chloggen/mx-psi_requests-remove-methods.yaml | 2 +- exporter/exporterhelper/request.go | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.chloggen/mx-psi_requests-remove-methods.yaml b/.chloggen/mx-psi_requests-remove-methods.yaml index 997ae9968e29..ec370d43bf07 100644 --- a/.chloggen/mx-psi_requests-remove-methods.yaml +++ b/.chloggen/mx-psi_requests-remove-methods.yaml @@ -7,7 +7,7 @@ change_type: deprecation component: exporterhelper # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). -note: Deprecate exporterhelper.RequestErrorHandler and exporterhelper.RequestSizer +note: Deprecate exporterhelper.RequestSizer # One or more tracking issues or pull requests related to the change issues: [13804] diff --git a/exporter/exporterhelper/request.go b/exporter/exporterhelper/request.go index 852e2de787ad..e6312054af60 100644 --- a/exporter/exporterhelper/request.go +++ b/exporter/exporterhelper/request.go @@ -15,7 +15,6 @@ import ( // until https://github.com/open-telemetry/opentelemetry-collector/issues/8122 is resolved. type Request = request.Request -// Deprecated [v0.136.0]: will be removed in the next minor version. // RequestErrorHandler is an optional interface that can be implemented by Request to provide a way handle partial // temporary failures. For example, if some items failed to process and can be retried, this interface allows to // return a new Request that contains the items left to be sent. Otherwise, the original Request should be returned.