Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension] ModuleInfo does not report providers #12372

Open
jackgopack4 opened this issue Feb 12, 2025 · 8 comments · May be fixed by #12385
Open

[extension] ModuleInfo does not report providers #12372

jackgopack4 opened this issue Feb 12, 2025 · 8 comments · May be fixed by #12385

Comments

@jackgopack4
Copy link
Contributor

Component(s)

extension/x

Describe the issue you're reporting

Currently, ModuleInfo struct available to Extensions does not list providers. Given that these are registered components and able to be configured in the builder-config.yaml, they should be available.

#12296 moved this code to "go.opentelemetry.io/collector/service/internal/moduleinfo" so I would plan to add it there.

I don't see much downside to this; just making available info about the collector that the user either built or installed.

Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@swiatekm
Copy link
Contributor

Looks like I was pinged here by mistake, as this isn't really about the storage interface. Pinging @mx-psi who is the author of the original change and should be able to help better here.

@jackgopack4
Copy link
Contributor Author

sorry, I didn't see [extension] as an option

@mx-psi
Copy link
Member

mx-psi commented Feb 13, 2025

@mowies could you take a look at why @swiatekm was pinged?

@jackgopack4 I would be in favor of this

@mowies
Copy link
Member

mowies commented Feb 13, 2025

he was pinged because he is listed as codeowner for extension/xextension both in CODEOWNERS and in https://github.com/open-telemetry/opentelemetry-collector/blob/main/extension/xextension/metadata.yaml#L7

@mx-psi
Copy link
Member

mx-psi commented Feb 13, 2025

Ah, I didn't catch this. He should be listed as a codeowner of extension/xextension/storage instead.

@mowies
Copy link
Member

mowies commented Feb 13, 2025

then we'll need another metadata.yaml file in that folder :)
and ideally somebody else as codeowner for the parent folder 🤷🏼

@mowies
Copy link
Member

mowies commented Feb 13, 2025

created #12382 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants