[ci] update semconv deepguard rule to allow v1.39.0#45452
Merged
Conversation
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
paulojmdias
added
the
Skip Changelog
mx-psi
reviewed
Jan 16, 2026
Member
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
Would it be possible to bump the v1.38.0 usages to v1.39.0 and ban v1.38.0?
Member
Author
Yes, I'll open a PR and link it to this one 👍 |
mx-psi
approved these changes
Jan 16, 2026
songy23
approved these changes
Jan 16, 2026
Member
Author
|
Are there some breaking changes around at least RPC and Messaging, which could affect some components, I'll check, but probably I'll open some issues to track some possible breaking changes. So, maybe shouldn't be quick to remove the v1.38.0 support. internal/coreinternal/goldendataset/generator_commons.go:1: : # github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal/goldendataset [github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal/goldendataset.test]
goldendataset/span_generator.go:320:36: undefined: conventions.RPCServiceKey
goldendataset/span_generator.go:327:36: undefined: conventions.RPCServiceKey
goldendataset/span_generator.go:354:36: undefined: conventions.PeerServiceKey (typecheck)
// Copyright The OpenTelemetry Authors
make: *** [lint] Error 1 |
Member
|
Thank's @paulojmdias . I also hit some issues at #45447 (comment). |
Member
Author
Same here while I'm trying evaluate the bumps. connector/exceptionsconnector/connector_logs_test.go:11:2: could not import go.opentelemetry.io/collector/component/componenttest (/Users/user/go/pkg/mod/go.opentelemetry.io/collector/component/componenttest@v0.143.1-0.20260115162016-5e41fb551263/telemetry.go:11:12: could not import go.opentelemetry.io/otel/sdk/metric (/Users/user/go/pkg/mod/go.opentelemetry.io/otel/sdk/metric@v1.39.0/config.go:14:2: could not import go.opentelemetry.io/otel (/Users/user/go/pkg/mod/go.opentelemetry.io/otel@v1.39.1-0.20260115134311-f809f7d71e2d/handler.go:7:2: could not import go.opentelemetry.io/otel/internal/global (-: # go.opentelemetry.io/otel/internal/global
/Users/user/go/pkg/mod/go.opentelemetry.io/otel@v1.39.1-0.20260115134311-f809f7d71e2d/internal/global/instruments.go:234:38: ctr.(metric.Float64Counter).Enabled undefined (type metric.Float64Counter has no field or method Enabled)
/Users/user/go/pkg/mod/go.opentelemetry.io/otel@v1.39.1-0.20260115134311-f809f7d71e2d/internal/global/instruments.go:267:44: ctr.(metric.Float64UpDownCounter).Enabled undefined (type metric.Float64UpDownCounter has no field or method Enabled)
/Users/user/go/pkg/mod/go.opentelemetry.io/otel@v1.39.1-0.20260115134311-f809f7d71e2d/internal/global/instruments.go:300:40: ctr.(metric.Float64Histogram).Enabled undefined (type metric.Float64Histogram has no field or method Enabled)
/Users/user/go/pkg/mod/go.opentelemetry.io/otel@v1.39.1-0.20260115134311-f809f7d71e2d/internal/global/instruments.go:333:36: ctr.(metric.Float64Gauge).Enabled undefined (type metric.Float64Gauge has no field or method Enabled)
/Users/user/go/pkg/mod/go.opentelemetry.io/otel@v1.39.1-0.20260115134311-f809f7d71e2d/internal/global/instruments.go:366:36: ctr.(metric.Int64Counter).Enabled undefined (type metric.Int64Counter has no field or method Enabled)
/Users/user/go/pkg/mod/go.opentelemetry.io/otel@v1.39.1-0.20260115134311-f809f7d71e2d/internal/global/instruments.go:399:42: ctr.(metric.Int64UpDownCounter).Enabled undefined (type metric.Int64UpDownCounter has no field or method Enabled)
/Users/user/go/pkg/mod/go.opentelemetry.io/otel@v1.39.1-0.20260115134311-f809f7d71e2d/internal/global/instruments.go:432:38: ctr.(metric.Int64Histogram).Enabled undefined (type metric.Int64Histogram has no field or method Enabled)
/Users/user/go/pkg/mod/go.opentelemetry.io/otel@v1.39.1-0.20260115134311-f809f7d71e2d/internal/global/instruments.go:465:34: ctr.(metric.Int64Gauge).Enabled undefined (type metric.Int64Gauge has no field or method Enabled))))) (typecheck)
"go.opentelemetry.io/collector/component/componenttest"
^
make: *** [lint] Error 1 |
aknuds1
pushed a commit
to aknuds1/opentelemetry-collector-contrib
that referenced
this pull request
Jan 20, 2026
…5452) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Allow usage of the latest semantic conventions package version v1.39.0 Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow usage of the latest semantic conventions package version v1.39.0