Skip to content

[awsxrayexporter] Generate url section in xray segment when net.peer.name is available#36530

Merged
TylerHelmuth merged 1 commit into
open-telemetry:mainfrom
bjrara:main
Dec 5, 2024
Merged

[awsxrayexporter] Generate url section in xray segment when net.peer.name is available#36530
TylerHelmuth merged 1 commit into
open-telemetry:mainfrom
bjrara:main

Conversation

@bjrara

@bjrara bjrara commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

Description

Generate url section in X-Ray segment when net.peer.name is available

Link to tracking issue

Fixes #35375.

Testing

Unit test

@bjrara bjrara requested a review from a team as a code owner November 26, 2024 00:00
@bjrara bjrara requested a review from fatsheep9146 November 26, 2024 00:00
@github-actions github-actions Bot requested review from srprash and wangzlei November 26, 2024 00:01
@bjrara bjrara changed the title Generate url section in xray segment when net.peer.name is available [xrayexporter] Generate url section in xray segment when net.peer.name is available Nov 27, 2024
@bjrara bjrara changed the title [xrayexporter] Generate url section in xray segment when net.peer.name is available [awsxrayexporter] Generate url section in xray segment when net.peer.name is available Nov 27, 2024

@wangzlei wangzlei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TylerHelmuth TylerHelmuth merged commit 3fdb51b into open-telemetry:main Dec 5, 2024
@github-actions github-actions Bot added this to the next release milestone Dec 5, 2024
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2024
…name is available (open-telemetry#36530)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Generate url section in X-Ray segment when net.peer.name is available

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes
open-telemetry#35375.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit test
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…name is available (open-telemetry#36530)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Generate url section in X-Ray segment when net.peer.name is available

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes
open-telemetry#35375.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit test
AkhigbeEromo pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Jan 13, 2025
…name is available (open-telemetry#36530)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Generate url section in X-Ray segment when net.peer.name is available

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes
open-telemetry#35375.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit test
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2025
…name is available (open-telemetry#36530)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Generate url section in X-Ray segment when net.peer.name is available

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes
open-telemetry#35375.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit test
zeck-ops pushed a commit to zeck-ops/opentelemetry-collector-contrib that referenced this pull request Apr 23, 2025
…name is available (open-telemetry#36530)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Generate url section in X-Ray segment when net.peer.name is available

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes
open-telemetry#35375.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing url from X-Ray segment

4 participants